Skip to content

Add contract contribution quality gate #484

Description

@El-swaggerito

Description

Difficulty: Expert

Type: Test

Summary

Add a contribution quality gate for PocketPay contract issues.

Current Behaviour

Merged contract PRs may include small changes without enough tests or with failing checks.

Expected Behaviour

The contracts repo should provide objective criteria for payment-ready work, including meaningful implementation, passing tests, and acceptance criteria coverage.

Suggested Implementation

Create quality gate documentation, PR template references, contract-specific testing expectations, and examples of incomplete work.

Files or Areas Likely Affected

  • docs/
  • .github/
  • README.md
  • tests/
  • Makefile

Acceptance Criteria

  • Contract quality gate checklist is added.
  • Checklist covers implementation, tests, CI, and acceptance criteria.
  • Contract-specific test expectations are included.
  • PR template references the quality gate.
  • Examples of incomplete work are documented.
  • README links to the quality gate.

Additional Notes

This helps prevent low-effort merged PRs from being treated as automatically approved.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked for GrantFox OSS contributionMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Official GrantFox campaign labelciCI and workflow workcontractSmart contract related workdeveloper-experienceDeveloper experience workexpertExpert difficultysorobanSoroban smart contract worktestTesting work

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions