Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment crash fix. #34

Open
tony-gutierrez opened this issue Feb 12, 2018 · 1 comment
Open

Deployment crash fix. #34

tony-gutierrez opened this issue Feb 12, 2018 · 1 comment

Comments

@tony-gutierrez
Copy link

When deploying repos created with a node version differing from that of the app service, and containing package-lock.json, the app service is often unable to do "npm install" correctly. It will complete, but not install the correct modules, and the node runtime will fail.

I modified my kudu deployment script to remove package-lock.json before the npm install.

Also, the purpose and behavior of package-lock.json is somewhat in flux: npm/npm#18103

At the very least, maybe add a warning to only use package-lock if you are deving on the exact same version your app service is running.

@tony-gutierrez
Copy link
Author

npm/npm#17979 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant