Minor formatting and test fixes

Author: simonkurtz-MSFT

shared/python/utils.py

@@ -212,7 +212,7 @@ def create_infrastructure(self, bypass_infrastructure_check: bool = False, allow
 
             return True
 
-        except (KeyboardInterrupt, EOFError) as exc:  # pragma: no cover
+        except (KeyboardInterrupt, EOFError):  # pragma: no cover
             print_error('\nInfrastructure deployment cancelled by user.')
             return False
         except Exception as e:  # pragma: no cover
@@ -810,7 +810,7 @@ def does_infrastructure_exist(infrastructure: INFRASTRUCTURE, index: int, allow_
 
                 if choice == '1':
                     return False  # Allow deployment to proceed
-                elif choice == '2' or choice == '3':
+                elif choice in ('2', '3'):
                     return True  # Block deployment
                 elif not choice:
                     # Empty input (ESC pressed in Jupyter) - cancel

tests/python/check_python.ps1

@@ -153,7 +153,7 @@ Write-Host "╚═════════════════════
 Write-Host ""
 
 # Determine statuses
-$LintStatus = if ($LintExitCode -eq 0) { "✅ PASSED" } else { "⚠️  ISSUES FOUND" }
+$LintStatus = if ($LintExitCode -eq 0) { "✅ PASSED" } else { "⚠️  ISSUES FOUND" } # leave two spaces after yellow triangle to display correctly
 $TestStatus = if ($FailedTests -eq 0) { "✅ PASSED" } else { "❌ FAILED" }
 
 # Get pylint score
@@ -168,11 +168,7 @@ if (Test-Path $LatestPylintText) {
 
 # Set colors
 $LintColor = if ($LintExitCode -eq 0) { "Green" } else { "Yellow" }
-$TestColor = if ($TestExitCode -eq 0) { "Green" } else { "Red" }
-
-# Calculate column widths for alignment
-$LabelWidth = "Pylint   :".Length  # 7
-$Padding = " " * ($LabelWidth - 1)
+$TestColor = if ($FailedTests -eq 0) { "Green" } else { "Red" }
 
 # Display Pylint status with score
 Write-Host "Pylint   : " -NoNewline

tests/python/check_python.sh

@@ -116,7 +116,7 @@ echo ""
 if [ $LINT_EXIT_CODE -eq 0 ]; then
     LINT_STATUS="✅ PASSED"
 else
-    LINT_STATUS="⚠️  ISSUES FOUND"
+    LINT_STATUS="⚠️  ISSUES FOUND" # leave two spaces after yellow triangle to display correctly
 fi
 
 # Determine Test status
@@ -132,7 +132,11 @@ if [ -n "$PYLINT_SCORE" ]; then
     echo "             ($PYLINT_SCORE)"
 fi
 
-echo "Tests    : $TEST_STATUS"
+if [ $FAILED_TESTS -eq 0 ]; then
+    echo "Tests    : $TEST_STATUS"
+else
+    echo -e "Tests    : \e[31m$TEST_STATUS\e[0m"  # Red color for failed tests
+fi
 if [ $TOTAL_TESTS -gt 0 ]; then
     # Calculate percentages (using bc for floating point)
     PASSED_PERCENT=$(echo "scale=2; $PASSED_TESTS / $TOTAL_TESTS * 100" | bc)

tests/python/test_utils.py

@@ -993,8 +993,8 @@ def test_prompt_for_infrastructure_update_option_1(monkeypatch):
     assert result == (True, None)
 
 def test_prompt_for_infrastructure_update_option_1_default(monkeypatch):
-    """Test _prompt_for_infrastructure_update when user presses Enter (defaults to option 1)."""
-    monkeypatch.setattr('builtins.input', lambda prompt: '')
+    """Test _prompt_for_infrastructure_update when user selects option 1 explicitly."""
+    monkeypatch.setattr('builtins.input', lambda prompt: '1')
 
     result = utils._prompt_for_infrastructure_update('test-rg')
     assert result == (True, None)