Skip to content

Commit 051fef3

Browse files
authored
Merge pull request #35 from Azure-Samples/gk/storage-fix
Improves development environment and access control
2 parents e685dcc + d388f44 commit 051fef3

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

.devcontainer/devcontainer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"name": "Azure Functions DevContainer",
2+
"name": "Snippy - Azure Functions DevContainer",
33
"dockerFile": "Dockerfile",
4-
"postCreateCommand": "./.devcontainer/setup.sh",
5-
"postStartCommand": "bash .devcontainer/start.sh"
6-
}
4+
"postCreateCommand": "/bin/sh .devcontainer/setup.sh",
5+
"postStartCommand": "/bin/sh .devcontainer/start.sh"
6+
}

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Always normalize shell scripts to LF
2+
*.sh text eol=lf

infra/main.bicep

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ var StorageBlobDataOwner = 'b7e6dc6d-f1e8-4753-8033-0f276bb0955b'
8686
var StorageQueueDataContributor = '974c5e8b-45b9-4653-ba55-5f855dd0fb88'
8787

8888
// Allow access from api to blob storage using a managed identity
89-
module blobRoleAssignmentApi 'app/rbac/storage-Access.bicep' = {
89+
module blobRoleAssignmentApi 'app/rbac/storage-access.bicep' = {
9090
name: 'blobRoleAssignmentapi'
9191
scope: rg
9292
params: {
@@ -97,7 +97,7 @@ module blobRoleAssignmentApi 'app/rbac/storage-Access.bicep' = {
9797
}
9898

9999
// Allow access from api to queue storage using a managed identity
100-
module queueRoleAssignmentApi 'app/rbac/storage-Access.bicep' = {
100+
module queueRoleAssignmentApi 'app/rbac/storage-access.bicep' = {
101101
name: 'queueRoleAssignmentapi'
102102
scope: rg
103103
params: {
@@ -185,7 +185,7 @@ module aiProject './app/ai/ai-project.bicep' = {
185185

186186
// Allow access from api to AI Project
187187
var AzureAiDeveloper = '64702f94-c441-49e6-a78b-ef80e0188fee'
188-
module aiProjectRoleAssignmentApi 'app/rbac/ai-project-Access.bicep' = {
188+
module aiProjectRoleAssignmentApi 'app/rbac/ai-project-access.bicep' = {
189189
name: 'aiProjectRoleAssignmentApi'
190190
scope: rg
191191
params: {

0 commit comments

Comments
 (0)