From 89ef266ae0469f119bfcc3dadc37065108ee0477 Mon Sep 17 00:00:00 2001
From: kimorris27 <kimorris@redhat.com>
Date: Thu, 10 Oct 2024 15:39:13 -0500
Subject: [PATCH] Nitpick test case names for clarity and test data for
 correctness

---
 pkg/cluster/delete_test.go | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/pkg/cluster/delete_test.go b/pkg/cluster/delete_test.go
index 3090dfc2f0a..051d4694e55 100644
--- a/pkg/cluster/delete_test.go
+++ b/pkg/cluster/delete_test.go
@@ -510,7 +510,7 @@ func TestDeleteFederatedCredentials(t *testing.T) {
 		wantErr string
 	}{
 		{
-			name: "success - cluster properties has nil Platform Workload Identity Profile",
+			name: "success - cluster doc has nil PlatformWorkloadIdentities",
 			doc: &api.OpenShiftClusterDocument{
 				ID: mockGuid,
 				OpenShiftCluster: &api.OpenShiftCluster{
@@ -527,7 +527,7 @@ func TestDeleteFederatedCredentials(t *testing.T) {
 			wantErr: "",
 		},
 		{
-			name: "success - cluster properties has non-nil Platform Workload Identity Profile but empty PlatformWorkloadIdentities list",
+			name: "success - cluster doc has non-nil but empty PlatformWorkloadIdentities",
 			doc: &api.OpenShiftClusterDocument{
 				ID: mockGuid,
 				OpenShiftCluster: &api.OpenShiftCluster{
@@ -545,7 +545,7 @@ func TestDeleteFederatedCredentials(t *testing.T) {
 			wantErr: "",
 		},
 		{
-			name: "success - successfully deleted federated credentials for platform workload Identity",
+			name: "success - successfully delete federated credentials",
 			doc: &api.OpenShiftClusterDocument{
 				ID: docID,
 				OpenShiftCluster: &api.OpenShiftCluster{
@@ -573,7 +573,7 @@ func TestDeleteFederatedCredentials(t *testing.T) {
 			wantErr: "",
 		},
 		{
-			name: "Success - Operator name do not exists in PlatformWorkloadIdentityProfile",
+			name: "success - skip federated credential deletion because platform workload identities are missing the OperatorName field",
 			doc: &api.OpenShiftClusterDocument{
 				ID: docID,
 				OpenShiftCluster: &api.OpenShiftCluster{
@@ -586,12 +586,10 @@ func TestDeleteFederatedCredentials(t *testing.T) {
 							UpgradeableTo: ptr.To(api.UpgradeableTo("4.15.40")),
 							PlatformWorkloadIdentities: []api.PlatformWorkloadIdentity{
 								{
-									OperatorName: "CloudControllerManager",
-									ResourceID:   fmt.Sprintf("%s/%s", resourceID, "ccm"),
+									ResourceID: fmt.Sprintf("%s/%s", resourceID, "ccm"),
 								},
 								{
-									OperatorName: "ClusterIngressOperator",
-									ResourceID:   fmt.Sprintf("%s/%s", resourceID, "cio"),
+									ResourceID: fmt.Sprintf("%s/%s", resourceID, "cio"),
 								},
 							},
 						},
@@ -601,7 +599,7 @@ func TestDeleteFederatedCredentials(t *testing.T) {
 			wantErr: "",
 		},
 		{
-			name: "error - error deleting federated credentials for platform workload Identity",
+			name: "error - encounter blocking error deleting a federated credential",
 			doc: &api.OpenShiftClusterDocument{
 				ID: docID,
 				OpenShiftCluster: &api.OpenShiftCluster{