Remove aro build tag as it's not needed for the ARO-RP #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jewzaam,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
bennerv
force-pushed
the
remove-aro-buildtag
branch
from
4f5a0f4
to
03180ad
Compare
hawkowl
approved these changes
Jan 3, 2024
LiniSusan
pushed a commit
to LiniSusan/ARO-RP
that referenced
this pull request
Jan 25, 2024
ventifus
pushed a commit
to ventifus/ARO-RP
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Removes unnecessary build tag.
What this PR does / why we need it:
The build tag is set in the installer, not in the RP anymore.
Test plan for issue:
e2e, ci
Is there any documentation that needs to be updated for this PR?
no-