Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-2016-alwayson - Allow all NSG Rule #378

Open
DarrylvanderPeijl opened this issue Sep 28, 2018 · 1 comment
Open

sql-2016-alwayson - Allow all NSG Rule #378

DarrylvanderPeijl opened this issue Sep 28, 2018 · 1 comment

Comments

@DarrylvanderPeijl
Copy link

@JeffGoldner

This resource is added to the NSG which opens up everything.
IMO this does not set a good example, rather leave it default and state something about NSG rules in the readme?

    "resources": [
        {
            "name": "[variables('nsgName')]",
            "location": "[resourceGroup().location]",
            "type": "Microsoft.Network/networkSecurityGroups",
            "apiVersion": "2015-06-15",
            "properties": {
                "securityRules": [
                    {
                        "name": "rule1",
                        "properties": {
                            "protocol": "*",
                            "sourcePortRange": "*",
                            "destinationPortRange": "*",
                            "sourceAddressPrefix": "*",
                            "destinationAddressPrefix": "*",
                            "access": "Allow",
                            "priority": 101,
                            "direction": "Inbound"
                        }
                    }
                ]
            }
        },
@pagariyaalok
Copy link
Contributor

@pappleby64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants