Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectedk8s - move to microsoft graph from the legacy aad graph call #6485

Open
bganapa opened this issue Jul 6, 2023 · 6 comments
Open
Labels
AAD Graph Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. Connected Kubernetes Service Attention This issue is responsible by Azure service team.

Comments

@bganapa
Copy link
Member

bganapa commented Jul 6, 2023

Describe the bug

Azure AD graph is on the path of deprecation. Microsoft Graph should be used for the graph calls
https://devblogs.microsoft.com/microsoft365dev/microsoft-graph-or-azure-ad-graph/

code path -

sub_filters.append("displayName eq '{}'".format("Custom Locations RP"))

Related command

az connectedk8s enable-features -n balacluster2 -g baladelete2 --features cluster-connect custom-locations --debug

This is making the following graph call
urllib3.connectionpool: https://graph.windows.net:443 "GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipals?$filter=displayName%20eq%20%27Custom%20Locations%20RP%27&api-version=1.6 HTTP/1.1" 200 1246

Errors

No errors in Azure.

Issue script & Debug output

urllib3.connectionpool: https://graph.windows.net:443 "GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipals?$filter=displayName%20eq%20%27Custom%20Locations%20RP%27&api-version=1.6 HTTP/1.1" 200 1246

Expected behavior

N/A

Environment Summary

N/A

Additional context

The issue happens in disconnected clouds where only the latest Microsoft Graph is supported

@bganapa bganapa added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jul 6, 2023
@ghost ghost added Auto-Assign Auto assign by bot Connected Kubernetes labels Jul 6, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 6, 2023

Thank you for opening this issue, we will look into it.

@ghost ghost added the CXP Attention This issue is handled by CXP team. label Jul 6, 2023
@bganapa bganapa changed the title connectek8s - move to microsoft graph from the legacy aad graph call connectedk8s - move to microsoft graph from the legacy aad graph call Jul 6, 2023
@SaurabhSharma-MSFT SaurabhSharma-MSFT self-assigned this Jul 6, 2023
@bganapa
Copy link
Member Author

bganapa commented Jul 10, 2023

@SaurabhSharma-MSFT Are you planning to fix this? If yes, could you pls provide any ETA?

@SaurabhSharma-MSFT SaurabhSharma-MSFT removed their assignment Jul 11, 2023
@SaurabhSharma-MSFT SaurabhSharma-MSFT added Service Attention This issue is responsible by Azure service team. and removed CXP Attention This issue is handled by CXP team. labels Jul 11, 2023
@ghost
Copy link

ghost commented Jul 11, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @akashkeshari.

Issue Details

Describe the bug

Azure AD graph is on the path of deprecation. Microsoft Graph should be used for the graph calls
https://devblogs.microsoft.com/microsoft365dev/microsoft-graph-or-azure-ad-graph/

code path -

sub_filters.append("displayName eq '{}'".format("Custom Locations RP"))

Related command

az connectedk8s enable-features -n balacluster2 -g baladelete2 --features cluster-connect custom-locations --debug

This is making the following graph call
urllib3.connectionpool: https://graph.windows.net:443 "GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipals?$filter=displayName%20eq%20%27Custom%20Locations%20RP%27&api-version=1.6 HTTP/1.1" 200 1246

Errors

No errors in Azure.

Issue script & Debug output

urllib3.connectionpool: https://graph.windows.net:443 "GET /72f988bf-86f1-41af-91ab-2d7cd011db47/servicePrincipals?$filter=displayName%20eq%20%27Custom%20Locations%20RP%27&api-version=1.6 HTTP/1.1" 200 1246

Expected behavior

N/A

Environment Summary

N/A

Additional context

The issue happens in disconnected clouds where only the latest Microsoft Graph is supported

Author: bganapa
Assignees: -
Labels:

bug, Service Attention, Connected Kubernetes, Auto-Assign

Milestone: -

@mbashtovaya
Copy link
Member

@yonzhan Could you provide an ETA for this issue? We are getting flagged by AAD Team as they asked all users to migrate to MS Graph in Sept 2023.

Copy link
Contributor

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @akashkeshari.

@jiasli
Copy link
Member

jiasli commented Jan 4, 2024

The main CLI has provided a lightweight GraphClient to call Microsoft Graph API. The extension owner of connectedk8s can follow https://github.com/Azure/azure-cli/blob/dev/doc/microsoft_graph_client.md to migrate to Microsoft Graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAD Graph Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved. Connected Kubernetes Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

5 participants