Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectedk8s: query for custom location object id with app id instead of app display name #6486

Open
bganapa opened this issue Jul 6, 2023 · 5 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Connected Kubernetes Service Attention This issue is responsible by Azure service team.

Comments

@bganapa
Copy link
Member

bganapa commented Jul 6, 2023

Describe the bug

Display name is not guaranteed to be unique and relialble. Instead the custom location's first party app id should be used to query for its object id.

Custom location's Ap ID bc313c14-388c-4e7d-a58e-70017303ee3b is constant across all azure clouds. Thi id should be used to query for the object id.

sub_filters.append("displayName eq '{}'".format("Custom Locations RP"))

Related command

N/A

Errors

N/A

Issue script & Debug output

N/A

Expected behavior

N/A

Environment Summary

N/A

Additional context

in disconnected clouds, the first party apps are created with the same App ID, however Display names are not guaranteed to be the same.

@bganapa bganapa added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jul 6, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 6, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added Connected Kubernetes CXP Attention This issue is handled by CXP team. labels Jul 7, 2023
@ghost
Copy link

ghost commented Jul 7, 2023

Thank you for your feedback. This has been routed to the support team for assistance.

@navba-MSFT navba-MSFT added Service Attention This issue is responsible by Azure service team. and removed CXP Attention This issue is handled by CXP team. labels Jul 7, 2023
@ghost
Copy link

ghost commented Jul 7, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @akashkeshari.

Issue Details

Describe the bug

Display name is not guaranteed to be unique and relialble. Instead the custom location's first party app id should be used to query for its object id.

Custom location's Ap ID bc313c14-388c-4e7d-a58e-70017303ee3b is constant across all azure clouds. Thi id should be used to query for the object id.

sub_filters.append("displayName eq '{}'".format("Custom Locations RP"))

Related command

N/A

Errors

N/A

Issue script & Debug output

N/A

Expected behavior

N/A

Environment Summary

N/A

Additional context

in disconnected clouds, the first party apps are created with the same App ID, however Display names are not guaranteed to be the same.

Author: bganapa
Assignees: -
Labels:

bug, Service Attention, Connected Kubernetes

Milestone: -

@navba-MSFT
Copy link
Contributor

Non customer reported. Adding Service team to look into this.

@TheOnlyWei
Copy link
Contributor

TheOnlyWei commented Sep 28, 2023

@bganapa I made an update for this coincidentally:
#6677
It enforces the use of object id instead of app id (they are different). Basically, user needs to pass in object id of the SP associated with custom locations if they want to enable custom locations.
@navba-MSFT FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Connected Kubernetes Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants