Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate.py now requires an extra variable that should not be required #6515

Closed
vilit1 opened this issue Jul 13, 2023 · 2 comments · Fixed by #6521
Closed

generate.py now requires an extra variable that should not be required #6515

vilit1 opened this issue Jul 13, 2023 · 2 comments · Fixed by #6521
Assignees
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team bug This issue requires a change to an existing behavior in the product in order to be resolved.
Milestone

Comments

@vilit1
Copy link
Contributor

vilit1 commented Jul 13, 2023

Describe the bug

https://github.com/Azure/azure-cli-extensions/pull/6507/files

This pr added a variable, dependent file, which was not present before. Since this is a required variable, it is failing to run the script and breaking our builds.

I can see why this would be needed for some wheels and extensions but it is not needed for others. I can get around this by adding -d None to the command but this should not be necessary.

Related command

scripts\refdoc\generate.py -e path_to_wheel

Errors

generate.py: error: the following arguments are required: -d/--dependent-file

Issue script & Debug output

generate.py: error: the following arguments are required: -d/--dependent-file

Expected behavior

-d/--dependent-file should not be required.

Environment Summary

azure-cli 2.50.0

core 2.50.0
telemetry 1.0.8

Extensions:
azure-iot 0.21.4

Dependencies:
msal 1.22.0
azure-mgmt-resource 23.1.0b2

Python location 'C:\repo\venv38\Scripts\python.exe'
Extensions directory 'C:\repo\extensions'

Python (Windows) 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:37:02) [MSC v.1924 64 bit (AMD64)]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Additional context

No response

@vilit1 vilit1 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jul 13, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 13, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added the Azure CLI Team The command of the issue is owned by Azure CLI team label Jul 13, 2023
@wangzelin007
Copy link
Member

Hi @vilit1,
I didn't anticipate that other users would directly use our CI scripts.
I will create a pull request to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team bug This issue requires a change to an existing behavior in the product in order to be resolved.
Projects
None yet
3 participants