Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If restore fails, CI script should exit with an error #3783

Open
mattchenderson opened this issue Aug 7, 2024 · 0 comments · May be fixed by #3786
Open

If restore fails, CI script should exit with an error #3783

mattchenderson opened this issue Aug 7, 2024 · 0 comments · May be fixed by #3786
Assignees
@fabiocav @jviau @mattchenderson
Labels
area: engineering Engineering improvements needs-discussion

Comments

@mattchenderson
Copy link
Contributor

Version

N/A

Description

In check-vulnerabilities.ps1, we should probably capture the exit code from the dotnet restore command and possibly throw an error before we get to the package listing operation. If restore fails partially, the package listing can git tripped on versions in dependencies not getting snapped forward properly.

Steps to reproduce

This was encountered with early iterations of #3780, as the package was not on the feed.
@mattchenderson mattchenderson added bug area: engineering Engineering improvements labels Aug 7, 2024
@mattchenderson mattchenderson changed the title If restore fails, script should exit with an error If restore fails, CI script should exit with an error Aug 7, 2024
@Francisco-Gamino Francisco-Gamino linked a pull request Aug 9, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiocav fabiocav

@jviau jviau

@mattchenderson mattchenderson

Labels
area: engineering Engineering improvements needs-discussion
Projects
None yet
Milestone
No milestone
3 participants
@fabiocav @jviau @mattchenderson