Merge branch 'dev' into jviau/abort-channel

Author: jviau

NuGet.config

@@ -8,5 +8,6 @@
     <add key="AzureFunctionsRelease" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctionsRelease/nuget/v3/index.json" />
     <add key="AzureFunctionsPreRelease" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctionsPreRelease/nuget/v3/index.json" />
     <add key="AzureFunctionsTempStaging" value="https://azfunc.pkgs.visualstudio.com/e6a70c92-4128-439f-8012-382fe78d6396/_packaging/AzureFunctionsTempStaging/nuget/v3/index.json" />
+    <add key="AzureFunctionsInfra" value="https://pkgs.dev.azure.com/azfunc/public/_packaging/infra/nuget/v3/index.json" />
   </packageSources>
 </configuration>

eng/ci/templates/official/jobs/process-coldstart.yml

@@ -37,7 +37,6 @@ jobs:
       artifact: $(artifactName)
 
   steps:
-  - checkout: none
   - pwsh: |
         $sampleSize = $env:SAMPLE_SIZE
         $values = @()
@@ -98,15 +97,8 @@ jobs:
       scriptType: 'pscore'
       scriptLocation: 'inlineScript'
       inlineScript: |
-        $json = Get-Content -Path $(resultsJsonPath) -Raw
-        $dateTimeUtc = [datetimeoffset]::UtcNow
-
-        $query = @"
-        INSERT INTO ColdStart (DateTimeUtc, OS, Description, Document)
-        VALUES ('$dateTimeUtc', '${{ parameters.os }}', '${{ parameters.description }}', '$json')
-        "@
-
-        Invoke-Sqlcmd -ConnectionString "$(ColdStartResultsSqlConnectionString)" -Query $query
-
+        $env:PATH = [System.IO.Path]::Combine($env:USERPROFILE, ".dotnet", "tools") + ";$env:PATH"
+        dotnet tool install -g Microsoft.Azure.Functions.ColdStartDataWriter --prerelease
+        func-cold-start-data-writer --os '${{ parameters.os }}' --description '${{ parameters.description }}' --sql-connection '$(ColdStartResultsSqlConnectionString)' --document-file-path '$(resultsJsonPath)'
     displayName: Persist results
     condition: eq(variables['Build.Reason'], 'Schedule')

release_notes.md

@@ -11,3 +11,4 @@
 - Update HttpWorkerOptions to implement IOptionsFormatter (#11175)
 - Improved metadata binding validation (#11101)
 - Throw exception instead of timing out when worker channel exits before initializing gRPC (#10937)
+- Skip logging errors on gRPC client disconnect (#10572)

src/WebJobs.Script.Grpc/Server/FunctionRpcService.cs

@@ -2,16 +2,17 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
+using System.IO;
 using System.Reactive.Linq;
 using System.Threading;
 using System.Threading.Channels;
 using System.Threading.Tasks;
 using Grpc.Core;
+using Microsoft.AspNetCore.Connections;
 using Microsoft.Azure.WebJobs.Script.Eventing;
 using Microsoft.Azure.WebJobs.Script.Grpc.Eventing;
 using Microsoft.Azure.WebJobs.Script.Grpc.Messages;
 using Microsoft.Extensions.Logging;
-
 using MsgType = Microsoft.Azure.WebJobs.Script.Grpc.Messages.StreamingMessage.ContentOneofCase;
 
 namespace Microsoft.Azure.WebJobs.Script.Grpc
@@ -75,6 +76,14 @@ static Task<Task<bool>> MoveNextAsync(IAsyncStreamReader<StreamingMessage> reque
                     }
                 }
             }
+            catch (IOException ex) when (ex.InnerException is ConnectionAbortedException && context.CancellationToken.IsCancellationRequested)
+            {
+                // Expected when the client disconnects.
+                // Client side stream termination (e.g., process exit or network interruption)
+                // can cause MoveNext() to throw an IOException with a ConnectionAbortedException as the inner exception.
+                // If ServerCallContext's cancellation token is also canceled at this point, the exception can be safely ignored.
+                return;
+            }
             catch (Exception rpcException)
             {
                 // We catch the exception, just to report it, then re-throw it