Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating feed for 4.70.0 (Make net 8 default) #515

Open
wants to merge 1 commit into
base: release/main
Choose a base branch
from

Conversation

phenning
Copy link

Fixes #514

@phenning phenning requested a review from a team as a code owner February 27, 2024 16:43
@phenning
Copy link
Author

phenning commented Mar 4, 2024

@mattchenderson If you want to defer this until there is a more significant update to include, please close without merging.

@mattchenderson
Copy link
Contributor

@phenning Apologies for having missed this. I had thought that the default was a per-release singleton. I just remember hacking something and hitting issues with default collisions in the same release. I agree with making the change here, but should we also un-default .NET 6 on the in-process model? Regardless, at this point, we'll need to reapply the changes onto a newer version. We can try to align that with some updates we'll be making shortly. But I think we're fine to leave this open until we do that. I also want to ensure the generator doesn't somehow regress the default...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make net8.0 a default in the feed.
2 participants