Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.12.0 does not have a git tag #2560

Closed
Timple opened this issue Jan 18, 2024 · 8 comments
Closed

Version 1.12.0 does not have a git tag #2560

Timple opened this issue Jan 18, 2024 · 8 comments
Labels

Comments

@Timple
Copy link

Timple commented Jan 18, 2024

The template is a bit verbose, but version 1.12.0 does not have a git tag: https://github.com/Azure/azure-iot-sdk-c/tags

The other versions do. Can this be corrected?

@ericwolz
Copy link
Contributor

1.12.0 has not been release yet. Current version is 1.11

https://github.com/Azure/azure-iot-sdk-c/releases/tag/LTS_08_2023

@Timple
Copy link
Author

Timple commented Jan 19, 2024

Aah, my bad.

@Timple Timple closed this as completed Jan 19, 2024
@Timple
Copy link
Author

Timple commented Jan 19, 2024

But on the same note. Where is the 1.11 tag?

@Timple Timple reopened this Jan 19, 2024
@ericwolz
Copy link
Contributor

We are no longer creating a version tag, only the LTS tag. They both point to the same thing.

@Timple
Copy link
Author

Timple commented Jan 20, 2024

Ah that is a pitty. Your version.txt does show the three digit version number. So that is how our tooling correlates this with the releases.

Would it be a burden to add these tags? Otherwise we (and potentially others) need to maintain a shadow list of which tag corresponds to which version.

@besquivel-pivotal
Copy link

Ah that is a pitty. Your version.txt does show the three digit version number. So that is how our tooling correlates this with the releases.

Would it be a burden to add these tags? Otherwise we (and potentially others) need to maintain a shadow list of which tag corresponds to which version.

The tags used to be there. Our build references the version that is written in version.txt and it recently started failing because the 1.11.0 tag was removed.

@ericwol-msft, it would be a tremendous help if you kept the tags that were already created.

@RLeclair
Copy link
Member

Hi @besquivel-pivotal, I've gone ahead and added the 1.11.0 tag and added the 1.12.0 tag. Closing the issue now

@Timple
Copy link
Author

Timple commented Jan 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants