Unused function parameters still asserted non-null? #2929
Labels
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
question
The issue doesn't require a change to the product in order to be resolved. Most issues start as that
There are a handful of functions that have parameters that are unused (i.e.
(void) parameter;
) but still asserted to be non-null (e.g._az_PRECONDITION_NOT_NULL(parameter);
). In and of itself this is (probably?) not an issue, but the Azure IoT Middleware for FreeRTOS definitely calls at least one function with a hard-codedNULL
value.Thus, using the DPS to register a device through the Azure IoT Middleware for FreeRTOS results in the assertion being triggered.
I would have issued a PR that removed the assertion, but I noticed that same "assert non-null of an unused parameter" pattern in other functions. I would be happy to do the same to all functions where applicable, but if the maintainers would prefer an alternate approach I might be able to implement that.
I considered raising an issue against the Azure IoT Middleware for FreeRTOS instead, but I don't think there's easy access to an 'options' parameter in the applicable flow, and the parameter is unused anyway... Again, I'm open to potential paths forward.
To Reproduce
If requested I can provide a sample project that can run on a SiWx917 development board.
Setup
wifi_azure_iot_soc
project generatorAdditional context
The initial entrypoint from my firmware was
AzureIoTProvisioningClient_Register
.The text was updated successfully, but these errors were encountered: