From 4461d430fff744edab20f7da4f8907952902f379 Mon Sep 17 00:00:00 2001 From: Chidozie Ononiwu Date: Tue, 28 Jan 2025 13:46:35 -0800 Subject: [PATCH] Update go Language Settings and Detect-Api-Changes --- eng/common/scripts/Detect-Api-Changes.ps1 | 15 ++++++++------- eng/common/scripts/Save-Package-Properties.ps1 | 1 + eng/scripts/Language-Settings.ps1 | 8 +++----- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/eng/common/scripts/Detect-Api-Changes.ps1 b/eng/common/scripts/Detect-Api-Changes.ps1 index 72163ce66fda..531592d9ff2d 100644 --- a/eng/common/scripts/Detect-Api-Changes.ps1 +++ b/eng/common/scripts/Detect-Api-Changes.ps1 @@ -109,32 +109,33 @@ $packageProperties = Get-ChildItem -Recurse -Force "$configFileDir" ` foreach ($packagePropFile in $packageProperties) { $packageMetadata = Get-Content $packagePropFile | ConvertFrom-Json - Write-Host "Processing $($packageMetadata.ArtifactName)" + $artifactOrModuleName = $packageMetadata.ArtifactName ?? $packageMetadata.ModuleName + Write-Host "Processing $($artifactOrModuleName)" - $packages = &$FindArtifactForApiReviewFn $ArtifactPath $packageMetadata.ArtifactName + $packages = &$FindArtifactForApiReviewFn $ArtifactPath $artifactOrModuleName if ($packages) { $pkgPath = $packages.Values[0] - $isRequired = Should-Process-Package -pkgPath $pkgPath -packageName $($packageMetadata.ArtifactName) + $isRequired = Should-Process-Package -pkgPath $pkgPath -packageName $($artifactOrModuleName) Write-Host "Is API change detect required for $($packages.ArtifactName):$($isRequired)" if ($isRequired -eq $True) { $filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/") - $respCode = Submit-Request -filePath $filePath -packageName $($packageMetadata.ArtifactName) + $respCode = Submit-Request -filePath $filePath -packageName $($artifactOrModuleName) if ($respCode -ne '200') { - $responses[$($packageMetadata.ArtifactName)] = $respCode + $responses[$($artifactOrModuleName)] = $respCode } } else { - Write-Host "Pull request does not have any change for $($packageMetadata.ArtifactName)). Skipping API change detect." + Write-Host "Pull request does not have any change for $($artifactOrModuleName)). Skipping API change detect." } } else { - Write-Host "No package is found in artifact path to find API changes for $($packageMetadata.ArtifactName)" + Write-Host "No package is found in artifact path to find API changes for $($artifactOrModuleName)" } } diff --git a/eng/common/scripts/Save-Package-Properties.ps1 b/eng/common/scripts/Save-Package-Properties.ps1 index 0257e73a1545..b93ff0d4f9d2 100644 --- a/eng/common/scripts/Save-Package-Properties.ps1 +++ b/eng/common/scripts/Save-Package-Properties.ps1 @@ -141,6 +141,7 @@ foreach ($pkg in $allPackageProperties) Write-Host "Package Version: $($pkg.Version)" Write-Host "Package SDK Type: $($pkg.SdkType)" Write-Host "Artifact Name: $($pkg.ArtifactName)" + Write-Host "Module Name: $($pkg.ModuleName)" Write-Host "Release date: $($pkg.ReleaseStatus)" $configFilePrefix = $pkg.Name diff --git a/eng/scripts/Language-Settings.ps1 b/eng/scripts/Language-Settings.ps1 index a25fbf00e2f2..32934d369938 100644 --- a/eng/scripts/Language-Settings.ps1 +++ b/eng/scripts/Language-Settings.ps1 @@ -101,12 +101,10 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) $searchPath = Join-Path $RepoRoot "sdk" $pkgFiles = @() if ($serviceDirectory) { - $searchPath = Join-Path $searchPath $serviceDirectory "go.mod" - [array]$pkgFiles = @(Get-ChildItem $searchPath) - } else { - # If service directory is not passed in, find all modules - [array]$pkgFiles = Get-ChildItem -Path $searchPath -Include "go.mod" -Recurse + $searchPath = Join-Path $searchPath $serviceDirectory } + + [array]$pkgFiles = Get-ChildItem -Path $searchPath -Include "go.mod" -Recurse foreach ($pkgFile in $pkgFiles) {