Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultAzureCredential skipping managed identity in Azure Container Instances #23894

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chlowell
Copy link
Member

Closes #23890 by fixing a regression in #23273, which had DefaultAzureCredential interpret a non-JSON response to its IMDS probe as indicating the server isn't IMDS or a supported imitator (I've filled the test gap that enabled the regression). This behavior is reasonable for IMDS, which always responds with JSON, but incorrect in general because ACI managed identity responds to the probe with a flat string. Sadly, there's no good way to identify ACI as the host, so the fix here is to check for its error message in the response 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

DefaultAzureCredential in azidentity v1.8.0 rejects Azure Container Instance's IMDS
1 participant