Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unspecified ErrorCode should say "UNSPECIFIED" instead of "UNAVAILABLE" #23892

Open
NickKeller opened this issue Dec 27, 2024 · 2 comments
Open
Labels
Azure.Core feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@NickKeller
Copy link
Member

Feature Request

For clarity's sake, if the AzureError's response code is unspecified, the error message should say "ERROR CODE UNSPECIFIED", instead of what it currently does saying "ERROR CODE UNAVAILABLE". Since UNAVAILABLE is a legit http error code, it caused some confusion on my team when we were trying to debug an issue. I feel like it would be clearer to say "UNSPECIFIED", which is harder to mix up with an http error code

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 27, 2024
@chlowell
Copy link
Member

Do you have an example confusing error? I'm wondering whether we have a bug that omits the status code, which should always appear on the first text line. For example:

--------------------------------------------------------------------------------
RESPONSE 500: it didn't work
ERROR CODE UNAVAILABLE
--------------------------------------------------------------------------------
error details from server
--------------------------------------------------------------------------------

So the HTTP status code should always appear before the RP's error code, if any

@chlowell chlowell added Azure.Core feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 30, 2024
@NickKeller
Copy link
Member Author

NickKeller commented Dec 30, 2024

In this case the output is not due to the sdk, but we received output like this when checking for the status of an operation. We spent a while wondering why it would return a 200 with also "UNAVAILABLE".

Image

Ultimately we figured out it was not an issue, but it would be a lot clearer if it had said "UNSPECIFIED". We spent quite a bit of time trying to figure out if the load balancer was overriding the status code to 200 when we thought the underlying service returned a 503, due to the UNAVAILABLE messaging

To be clear, there is no "bug" here, just a messaging issue, imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants