Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Trim Warning with Azure.Data.Tables #47687

Open
wsugarman opened this issue Dec 29, 2024 · 3 comments
Open

[FEATURE REQ] Trim Warning with Azure.Data.Tables #47687

wsugarman opened this issue Dec 29, 2024 · 3 comments
Assignees
@christothes
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables

Comments

@wsugarman
Copy link
Contributor

Library name

Azure.Data.Tables

Please describe the feature.

Many of the Azure SDK packages have been making progress in becoming compatible with trimming for native AOT compilations. However, I see that Azure.Data.Tables has a few more issues to work through. When compiling a project of mine with <PublishAot>true</PublishAot>, I encountered the following warning:

15.90 ILC : Trim analysis error IL2091: Azure.Data.Tables.DictionaryTableExtensions.ToTableEntity(IDictionary`2<String,Object>,TypeBinder`1.BoundTypeInfo<IDictionary`2<String,Object>>): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in 'System.Activator.CreateInstance()'. The generic parameter 'T' of 'Azure.Data.Tables.DictionaryTableExtensions.ToTableEntity(IDictionary`2<String,Object>,TypeBinder`1.BoundTypeInfo<IDictionary`2<String,Object>>)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

Details for warning IL2091 can be found here: https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trim-warnings/il2091
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables labels Dec 29, 2024
@github-actions GitHub Actions
Copy link

@christothes @JonathanCrd

@github-actions GitHub Actions
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@jsquire
Copy link
Member

jsquire commented Dec 31, 2024

@m-redding : Would you mind taking a look and offering your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christothes christothes

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsquire @christothes @wsugarman