Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Automation] Spec repo azure-sdk-for-net-track2 CI failed for new RP #46862

Open
chunyu3 opened this issue Oct 28, 2024 · 8 comments · May be fixed by #47688
Open

[SDK Automation] Spec repo azure-sdk-for-net-track2 CI failed for new RP #46862

chunyu3 opened this issue Oct 28, 2024 · 8 comments · May be fixed by #47688
Assignees
Labels
Automation Mgmt This issue is related to a management-plane library.

Comments

@chunyu3
Copy link
Member

chunyu3 commented Oct 28, 2024

When there is a new RP onboard in azure-rest-api-specs, the CI failure

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4270662&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437&l=306

@chunyu3 chunyu3 self-assigned this Oct 28, 2024
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 28, 2024
@chunyu3
Copy link
Member Author

chunyu3 commented Oct 28, 2024

There are two problem:

  • The azure-rest-api-specs ci framework inputJson only contain the relatedReadmeMdFiles (regaring it as swagger project), no relatedTypeSpecProjectFolder
  • .NET automation failed to create the scaffolding for this new RP when it is from swagger.

@jsquire jsquire added Mgmt This issue is related to a management-plane library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 28, 2024
@chunyu3
Copy link
Member Author

chunyu3 commented Oct 30, 2024

Root cause:
The mgmt-plane sdk template/scaffolding now only suitable for typespec project. This is a swagger project (identified by the azure-rest-api-specs ci framework, maybe wrong), and it is a new service, so it tried to use mgmt-plane sdk template to generate the scaffolding which is not correct, the generated configure file is not correct.

@chunyu3 chunyu3 moved this from Backlog to In Progress in API to SDK automation Nov 7, 2024
@raych1
Copy link
Member

raych1 commented Nov 14, 2024

@chunyu3 , the policy requires all the new service use TypeSpec. Is this service an exception to use Swagger?

@chunyu3
Copy link
Member Author

chunyu3 commented Nov 15, 2024

@chunyu3 , the policy requires all the new service use TypeSpec. Is this service an exception to use Swagger?

@raych1 it uses TypeSpec. But the ci framework somehow identified it as swagger project by mistake.

@raych1
Copy link
Member

raych1 commented Dec 3, 2024

@chunyu3 is this a bug in the .NET automation scripts?

@chunyu3
Copy link
Member Author

chunyu3 commented Dec 3, 2024

@chunyu3 is this a bug in the .NET automation scripts?

Current new service of management-plane only can be generated from Typespec, so the mgmt-plane SDK scaffolding is only for TypeSpec project. But this is a swagger project, and the swagger have existed for a long time, but it does not generate .NET SDK. We cannot identify it is a green field service or brown field service.

We need to decide if we need to support scaffolding for this kind of project. If not, .NET automation will throw an error for this, skip the generation.

@raych1
Copy link
Member

raych1 commented Dec 9, 2024

@chunyu3 ok, this is the change needs to make in .NET automation script. What is the other issue you mentioned above for the SDK automation framework? Does it still exist?

@chunyu3
Copy link
Member Author

chunyu3 commented Dec 12, 2024

@chunyu3 ok, this is the change needs to make in .NET automation script. What is the other issue you mentioned above for the SDK automation framework? Does it still exist?

@raych1 The issue is because mgmt-plane will not support scaffolding for swagger project. So we will throw error if it is a swagger project but it is a new PR (no sdk package folder), and the whole .NET sdk automation still fail.

The automation framework issue does not exist.

@chunyu3 chunyu3 linked a pull request Dec 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Mgmt This issue is related to a management-plane library.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants