Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Trim additional polyfill packages #48084

Open
jsquire opened this issue Feb 3, 2025 · 0 comments
Open

[EngSys] Trim additional polyfill packages #48084

jsquire opened this issue Feb 3, 2025 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone

Comments

@jsquire
Copy link
Member

jsquire commented Feb 3, 2025

Summary

To ensure consistency across targets, polyfill packages are available on NuGet for these system features supported by netstandard2.0. On runtimes where the features are missing, the polyfill packages provide them. On runtimes where the features are natively available, the polyfill packages do nothing. This was helpful in the early days of .NET Core, where the runtime feature set was undergoing many changes. Starting with .NET 6, some of the features that the Azure SDK packages rely on are available natively in the runtime.

An initial wave of trimming for built-in features exists was added to Directory.Build.Common.targets and has been undergoing compatibility testing during our CI and nightly test runs.

We should be able to add the following packages as additional trims:

  • Microsoft.Bcl.AsyncInterfaces
  • System.Threading.Tasks.Extensions

Scope of work

  • Add the additional packages as targets for trimming
  • Run the Core and ResourceManager CI and nightly test pipelines to validate
  • Monitor CI and nightly failures across the Azure SDK for .NET packages for a week to find any regressions

Success criteria

CI and nightly test runs continue to pass consistently and reliably

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Feb 3, 2025
@jsquire jsquire added this to the 2025-04 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

2 participants