Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate scripts under scripts/typespec #48158

Open
JoshLove-msft opened this issue Feb 7, 2025 · 0 comments
Open

Remove duplicate scripts under scripts/typespec #48158

JoshLove-msft opened this issue Feb 7, 2025 · 0 comments
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation

Comments

@JoshLove-msft
Copy link
Member

There are some scripts defined for the Azure plugin under scripts/typespec that should be consolidated with the scripts under https://github.com/Azure/azure-sdk-for-net/tree/main/eng/packages/http-client-csharp/eng/scripts. Some of the scripts can probably be deleted, e.g. Generate-Code.ps1 is superseded by Generate.ps1.

The common yaml needs to be updated to point to the new location, so we will need to do this in a staged way:

_courtesy of @@m-nash

  1. duplicate the scripts in both /eng/scripts/typespec and /eng/packages/http-client-csharp/eng/scripts
  2. update https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/pipelines/templates/archetype-typespec-emitter.yml to point at new location
  3. merge the sync pr from azure-sdk-tools into the lang repos
  4. delete the scripts from /eng/scripts/typespec
@JoshLove-msft JoshLove-msft added the CodeGen Issues that relate to code generation label Feb 7, 2025
@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation
Projects
None yet
Development

No branches or pull requests

2 participants