Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Don't retry on AzureSigningError if missing credential information #26656

Closed
vincenttran-msft opened this issue Oct 5, 2022 · 2 comments
Closed

[Storage] Don't retry on AzureSigningError if missing credential information #26656

vincenttran-msft opened this issue Oct 5, 2022 · 2 comments
Assignees
@jalauzon-msft @vincenttran-msft
Labels
Storage Storage Service (Queues, Blobs, Files)

Comments

@vincenttran-msft
Copy link
Member

As discussed offline, there should be some logic that if a AzureSigningError occurs, to check if the credential provided is empty. It is slightly odd to wait for a retry (that we know will fail) if we were to inspect the credential and see that it is empty.
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 5, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.56265616,Azure.Identity:0.38987213,Event Hubs:0.0049533104'

@vincenttran-msft vincenttran-msft added Storage Storage Service (Queues, Blobs, Files) and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 5, 2022
@jalauzon-msft
Copy link
Member

Fixed with #36431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jalauzon-msft jalauzon-msft

@vincenttran-msft vincenttran-msft

Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azure-sdk @jalauzon-msft @vincenttran-msft