Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure.identity.aio.CertificateCredential constructor does not support x5c via send_certificate_chain #36441

Closed
gabloe opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@gabloe
Copy link

gabloe commented Jul 11, 2024

  • Package Name: azure.identity.aio.CertificateCredential
  • Package Version: 1.17.1
  • Operating System: multiple
  • Python Version: 3.11

Describe the bug
The constructors for azure.identity.CertificateCredential and azure.identity.aio.CertificateCredential are inconsistent. The aio version does not support the send_certificate_chain argument that the non-aio version supports. This means that SN+I is not possible in the aio version.

To Reproduce
Steps to reproduce the behavior:
Using an SPN configured for SN+I and without a pinned cert the following code fails with a invalid_client (AADSTS700027) error.

from azure.identity.aio import CertificateCredential

credential = CertificateCredential(
    tenant_id="<Your tenant id>",
    client_id="<Your client id>",
    certificate_path='<Your cert>',
    send_certificate_chain=True
)

await credential.get_token(".default")

Expected behavior
It should succeed

@github-actions github-actions bot added Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 11, 2024
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@xiangyan99
Copy link
Member

Thanks for reaching out.

We don't have async support for SNI certificate. #13349

Please use sync one as a work around.

@xiangyan99 xiangyan99 added the issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. label Jul 11, 2024
Copy link

Hi @gabloe. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

@github-actions github-actions bot removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Jul 11, 2024
Copy link

Hi @gabloe, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed The Azure SDK team member assisting with this issue believes it to be addressed and ready to close. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Development

No branches or pull requests

2 participants