Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Changes check is failing unexpectedly #36784

Closed
scbedd opened this issue Aug 6, 2024 · 4 comments · Fixed by #36794 or #36795
Closed

Breaking Changes check is failing unexpectedly #36784

scbedd opened this issue Aug 6, 2024 · 4 comments · Fixed by #36794 or #36795
Assignees
@msyyc

Comments

@scbedd
Copy link
Member

scbedd commented Aug 6, 2024

On more than a few pipelines.

Here is a kusto query that shows all the failures and which pipelines are affected.

Need to dig in and identify a resolution.
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 6, 2024
@scbedd
Copy link
Member Author

scbedd commented Aug 6, 2024

@msyyc I have reason to believe it's related to this PR #36601 can you please take a look?

@scbedd scbedd removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 6, 2024
@scbedd scbedd mentioned this issue Aug 6, 2024
Merged
@scbedd
Copy link
Member Author

scbedd commented Aug 6, 2024 •
edited
Loading

@msyyc also FYI. I disabled the breaking check individually for mgmt-importexport and mgmt-cosmosdb in #36785 , as they are blocking data plane releases. Please re-enable after you understand the failure.

@msyyc
Copy link
Member

msyyc commented Aug 7, 2024

Recently I adopted breaking change detector in #36601 however it blocks release. Then I find we could skip it by set Skip.BreakingChanges when running release pipeline #36370 (comment). I don't expect it blocks CI of other data-plane packages...
Thanks @scbedd for the fix and I think add breaking=false in pyproject.toml is better way and I will add it for all mgmt packages to avoid similar issues.

@msyyc msyyc mentioned this issue Aug 7, 2024
Merged
@msyyc msyyc mentioned this issue Aug 7, 2024
Merged
@scbedd
Copy link
Member Author

scbedd commented Aug 8, 2024

Yep agree with your assessment. Thanks @msyyc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyyc msyyc

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@scbedd @msyyc