Add Unit test for AMQP Client Link with max message size = 0 #43582
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a unit test to verify AMQP link negotiation behavior when the client sets max_message_size=0 (unlimited) and the server responds with a specific limit (20MB). The test ensures the link correctly adopts the server's limit as the final maximum message size.
Key Changes:
- Added test case
test_max_message_size_negotiation_with_client_unlimitedto validate AMQP attach frame negotiation - Imported additional dependencies (
Source,Target,Mock,patch,LINK_MAX_MESSAGE_SIZE) to support the new test
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_link.py
Outdated
Show resolved
Hide resolved
Contributor
|
Once the PR tests pass, we are good to merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines