Skip to content

Commit 64dcbf8

Browse files
Update common tool to support go
1 parent 25226b7 commit 64dcbf8

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

Diff for: eng/common/scripts/Detect-Api-Changes.ps1

+13-9
Original file line numberDiff line numberDiff line change
@@ -104,37 +104,41 @@ if (!($FindArtifactForApiReviewFn -and (Test-Path "Function:$FindArtifactForApiR
104104
$responses = @{}
105105

106106
$packageProperties = Get-ChildItem -Recurse -Force "$configFileDir" `
107-
| Where-Object { $_.Extension -eq '.json' }
107+
| Where-Object {
108+
$_.Extension -eq '.json' -and ($_.FullName.Substring($configFileDir.Length + 1) -notmatch '^_.*?\\')
109+
}
108110

109111
foreach ($packagePropFile in $packageProperties)
110112
{
111113
$packageMetadata = Get-Content $packagePropFile | ConvertFrom-Json
112-
Write-Host "Processing $($packageMetadata.ArtifactName)"
114+
$pkgArtifactName = $packageMetadata.ArtifactName ?? $packageMetadata.Name
115+
116+
Write-Host "Processing $($pkgArtifactName)"
113117

114-
$packages = &$FindArtifactForApiReviewFn $ArtifactPath $packageMetadata.ArtifactName
118+
$packages = &$FindArtifactForApiReviewFn $ArtifactPath $pkgArtifactName
115119

116120
if ($packages)
117121
{
118122
$pkgPath = $packages.Values[0]
119-
$isRequired = Should-Process-Package -pkgPath $pkgPath -packageName $($packageMetadata.ArtifactName)
120-
Write-Host "Is API change detect required for $($packages.ArtifactName):$($isRequired)"
123+
$isRequired = Should-Process-Package -pkgPath $pkgPath -packageName $pkgArtifactName
124+
Write-Host "Is API change detect required for $($pkgArtifactName):$($isRequired)"
121125
if ($isRequired -eq $True)
122126
{
123127
$filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/")
124-
$respCode = Submit-Request -filePath $filePath -packageName $($packageMetadata.ArtifactName)
128+
$respCode = Submit-Request -filePath $filePath -packageName $pkgArtifactName
125129
if ($respCode -ne '200')
126130
{
127-
$responses[$($packageMetadata.ArtifactName)] = $respCode
131+
$responses[$pkgArtifactName] = $respCode
128132
}
129133
}
130134
else
131135
{
132-
Write-Host "Pull request does not have any change for $($packageMetadata.ArtifactName)). Skipping API change detect."
136+
Write-Host "Pull request does not have any change for $($pkgArtifactName)). Skipping API change detect."
133137
}
134138
}
135139
else
136140
{
137-
Write-Host "No package is found in artifact path to find API changes for $($packageMetadata.ArtifactName)"
141+
Write-Host "No package is found in artifact path to find API changes for $($pkgArtifactName)"
138142
}
139143
}
140144

0 commit comments

Comments
 (0)