-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LintDiff] simplify CI/CD deployment / change management #7619
Comments
I discussed this with @mikeharder. First, we observed that await addPrereleaseNumber(changeCounts, packages);
if (Object.keys(changeCounts).length) {
updateOpenapiValidatorPck()
}
} const newVersion = changeCount === 0
? packageInfo.version // Use existing version. Bug in rush --partial-prerelease not working
: `${packageJsonContent.version}.${changeCount}`; i.e. if there are no files generated with
And in staging release /
as a result of this, for example, rulesets
We still want to simplify the process. The step we are planning to take:
This way:
Going forward, we plan to completely remove |
Related doc update work: |
Currently, when working with LintDiff, we leverage
rush change
(part ofrush prep
) andrush version --bump
(part of deployment to prod). This is confusing and hard to get right without good understanding what rush is doing. Recently I had to yet-again clean up the versioning state of the repo in recent PR Azure/azure-openapi-validator#657. For example, one needs to do following set of changes each time deploying to prod:The goal of this work item is to stop using these commands: instead of that the documentation will explain how to manually update relevant
changelog.md
and relevantpackage.json
files. As part of this work, the call torush change --verify
from the LintDiff PR CI needs to be removed.This work item subsumes large part of the previous work item of:
rush build
run and prevent local breakage #6141Related:
@weshaggard @mikeharder @AkhilaIlla @rkmanda @bdefoy FYI
The text was updated successfully, but these errors were encountered: