Skip to content

Adding support for Microsoft.Web sites/sourcecontrols#4491

Merged
theunrepentantgeek merged 3 commits intoAzure:mainfrom
nishant221:srcctrl-support
Jan 21, 2025
Merged

Adding support for Microsoft.Web sites/sourcecontrols#4491
theunrepentantgeek merged 3 commits intoAzure:mainfrom
nishant221:srcctrl-support

Conversation

@nishant221
Copy link
Copy Markdown
Contributor

Closes #4490

What this PR does

Add Support for Microsoft.Web sites/sourcecontrols

How does this PR make you feel? Excited :)

Checklist

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

│ │ │ └── RuntimeVersion: *string
│ │ ├── ContainerConfiguration: *Object (4 properties)
│ │ │ ├── ImageName: *string
│ │ │ ├── Password: *genruntime.SecretReference
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@theunrepentantgeek
Copy link
Copy Markdown
Member

/ok-to-test sha=cbf55fc

Comment thread v2/samples/web/v1api/v1api20220301_sitesourcecontrol.yaml
@nishant221
Copy link
Copy Markdown
Contributor Author

@theunrepentantgeek I have renamed the file as requested. Can you please have a relook. Thanks.

@nishant221
Copy link
Copy Markdown
Contributor Author

@theunrepentantgeek Gentle reminder : ) Can you please have a look and see if this can be merged.

@theunrepentantgeek
Copy link
Copy Markdown
Member

/ok-to-test sha=3a05eb5

@theunrepentantgeek
Copy link
Copy Markdown
Member

Looking good. I've triggered our CI pipeline to run.

@theunrepentantgeek theunrepentantgeek added this to the v2.12.0 milestone Jan 20, 2025
@theunrepentantgeek
Copy link
Copy Markdown
Member

CI builds are failing during replay of the test Test_Web_SitesSourcecontrol_CRUD.

Typically, these are easy to resolve. In most cases re-recording the test is sufficient. Sometimes, these failures indicate a need to implement a resource extension to customize the reconciliation.

I'll investigate to see if that's necessary, but in the meantime, it would be worth deleting the existing recording and re-recording the test with

TEST_FILTER=Test_Web_SitesSourcecontrol_CRUD TIMEOUT=60m task controller:test-integration-envtest

Once re-recorded, run the test again to ensure the recording does playback properly.

@nishant221
Copy link
Copy Markdown
Contributor Author

nishant221 commented Jan 21, 2025

@theunrepentantgeek I have re-recorded the test and re-ran it locally. It is showing as passed. Below screenshot for reference. Kindly take a look.

image

@theunrepentantgeek
Copy link
Copy Markdown
Member

Thanks for the update; I'll trigger our CI runs now.
(Side note: Your screenshot shows warning: no tests to run for both invocations, so I'm not sure that PASS will be valid.)

@theunrepentantgeek
Copy link
Copy Markdown
Member

I pulled your branch and ran that test locally with

TEST_FILTER=Test_Web_SitesSourcecontrol_CRUD TIMEOUT=60m task controller:test-integration-envtest

Test output included

[controller:test-integration-envtest] --- PASS: Test_Web_SitesSourcecontrol_CRUD (118.26s)

which looks really good.

CI is now running, hopefully it will return the same verdict.

@theunrepentantgeek
Copy link
Copy Markdown
Member

/ok-to-test sha=b4df8fb

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Jan 21, 2025
Merged via the queue into Azure:main with commit 87e627e Jan 21, 2025
@theunrepentantgeek
Copy link
Copy Markdown
Member

Thanks @nishant221, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Feature: Add Support for Microsoft.Web sites/sourcecontrols

3 participants