Skip to content

Commit 6074f32

Browse files
fix: Key Vault - Incorrect test value (#3398)
## Description Fixed incorrect test value in max test that was not reflecting the way the UDTs are implemented ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.key-vault.vault](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=users%2Falsehr%2FkvltParamFix&event=workflow_dispatch)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation
1 parent f44015a commit 6074f32

File tree

5 files changed

+38
-22
lines changed

5 files changed

+38
-22
lines changed

avm/res/key-vault/vault/README.md

+24-12
Original file line numberDiff line numberDiff line change
@@ -352,8 +352,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
352352
enableRbacAuthorization: false
353353
keys: [
354354
{
355-
attributesExp: 1725109032
356-
attributesNbf: 10000
355+
attributes: {
356+
exp: 1725109032
357+
nbf: 10000
358+
}
357359
name: 'keyName'
358360
roleAssignments: [
359361
{
@@ -495,8 +497,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
495497
]
496498
secrets: [
497499
{
498-
attributesExp: 1702648632
499-
attributesNbf: 10000
500+
attributes: {
501+
exp: 1725109032
502+
nbf: 10000
503+
}
500504
contentType: 'Something'
501505
name: 'secretName'
502506
roleAssignments: [
@@ -608,8 +612,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
608612
"keys": {
609613
"value": [
610614
{
611-
"attributesExp": 1725109032,
612-
"attributesNbf": 10000,
615+
"attributes": {
616+
"exp": 1725109032,
617+
"nbf": 10000
618+
},
613619
"name": "keyName",
614620
"roleAssignments": [
615621
{
@@ -763,8 +769,10 @@ module vault 'br/public:avm/res/key-vault/vault:<version>' = {
763769
"secrets": {
764770
"value": [
765771
{
766-
"attributesExp": 1702648632,
767-
"attributesNbf": 10000,
772+
"attributes": {
773+
"exp": 1725109032,
774+
"nbf": 10000
775+
},
768776
"contentType": "Something",
769777
"name": "secretName",
770778
"roleAssignments": [
@@ -870,8 +878,10 @@ param enablePurgeProtection = false
870878
param enableRbacAuthorization = false
871879
param keys = [
872880
{
873-
attributesExp: 1725109032
874-
attributesNbf: 10000
881+
attributes: {
882+
exp: 1725109032
883+
nbf: 10000
884+
}
875885
name: 'keyName'
876886
roleAssignments: [
877887
{
@@ -1013,8 +1023,10 @@ param roleAssignments = [
10131023
]
10141024
param secrets = [
10151025
{
1016-
attributesExp: 1702648632
1017-
attributesNbf: 10000
1026+
attributes: {
1027+
exp: 1725109032
1028+
nbf: 10000
1029+
}
10181030
contentType: 'Something'
10191031
name: 'secretName'
10201032
roleAssignments: [

avm/res/key-vault/vault/access-policy/main.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"metadata": {
66
"_generator": {
77
"name": "bicep",
8-
"version": "0.29.47.4906",
9-
"templateHash": "7494731697751039419"
8+
"version": "0.30.23.60470",
9+
"templateHash": "15469258025112973480"
1010
},
1111
"name": "Key Vault Access Policies",
1212
"description": "This module deploys a Key Vault Access Policy.",

avm/res/key-vault/vault/key/main.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"metadata": {
66
"_generator": {
77
"name": "bicep",
8-
"version": "0.30.3.12046",
9-
"templateHash": "13039550242026782790"
8+
"version": "0.30.23.60470",
9+
"templateHash": "796741209006922272"
1010
},
1111
"name": "Key Vault Keys",
1212
"description": "This module deploys a Key Vault Key.",

avm/res/key-vault/vault/secret/main.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"metadata": {
66
"_generator": {
77
"name": "bicep",
8-
"version": "0.29.47.4906",
9-
"templateHash": "114626909766354577"
8+
"version": "0.30.23.60470",
9+
"templateHash": "10121697157844029321"
1010
},
1111
"name": "Key Vault Secrets",
1212
"description": "This module deploys a Key Vault Secret.",

avm/res/key-vault/vault/tests/e2e/max/main.test.bicep

+8-4
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,10 @@ module testDeployment '../../../main.bicep' = [
123123
enableRbacAuthorization: false
124124
keys: [
125125
{
126-
attributesExp: 1725109032
127-
attributesNbf: 10000
126+
attributes: {
127+
exp: 1725109032
128+
nbf: 10000
129+
}
128130
name: 'keyName'
129131
roleAssignments: [
130132
{
@@ -274,8 +276,10 @@ module testDeployment '../../../main.bicep' = [
274276
]
275277
secrets: [
276278
{
277-
attributesExp: 1702648632
278-
attributesNbf: 10000
279+
attributes: {
280+
exp: 1725109032
281+
nbf: 10000
282+
}
279283
contentType: 'Something'
280284
name: 'secretName'
281285
roleAssignments: [

0 commit comments

Comments
 (0)