Improve assertion for flaky test (#17796)

anthony-c-martin · web-flow · commit 567ca0a74dab · 2025-08-12T09:16:30.000-04:00
Improve assertion for flaky test
diff --git a/src/Bicep.Cli.UnitTests/Assertions/CliResultAssertions.cs b/src/Bicep.Cli.UnitTests/Assertions/CliResultAssertions.cs
@@ -49,7 +49,11 @@ public AndConstraint<CliResultAssertions> HaveStdoutMatch(string stdout, string
     }
 
     public AndConstraint<CliResultAssertions> NotHaveStdout(string because = "", params object[] becauseArgs)
-        => HaveStdout("", because, becauseArgs);
+    {
+        Subject.Stdout.Should().BeEmpty(because, becauseArgs);
+
+        return new(this);
+    }
 
     public AndConstraint<CliResultAssertions> HaveStderr(string stderr, string because = "", params object[] becauseArgs)
     {
@@ -73,7 +77,11 @@ public AndConstraint<CliResultAssertions> NotHaveStderrMatch(string stderr, stri
     }
 
     public AndConstraint<CliResultAssertions> NotHaveStderr(string because = "", params object[] becauseArgs)
-        => HaveStderr("", because, becauseArgs);
+    {
+        Subject.Stderr.Should().BeEmpty(because, becauseArgs);
+
+        return new(this);
+    }
 
     public AndConstraint<CliResultAssertions> HaveCompileError(string? errorCode = null, string because = "", params object[] becauseArgs)
     {

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,11 @@ public AndConstraint<CliResultAssertions> HaveStdoutMatch(string stdout, string`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`public AndConstraint<CliResultAssertions> NotHaveStdout(string because = "", params object[] becauseArgs)`
`52`		`- => HaveStdout("", because, becauseArgs);`
	`52`	`+ {`
	`53`	`+ Subject.Stdout.Should().BeEmpty(because, becauseArgs);`
	`54`	`+`
	`55`	`+ return new(this);`
	`56`	`+ }`
`53`	`57`
`54`	`58`	`public AndConstraint<CliResultAssertions> HaveStderr(string stderr, string because = "", params object[] becauseArgs)`
`55`	`59`	`{`
`@@ -73,7 +77,11 @@ public AndConstraint<CliResultAssertions> NotHaveStderrMatch(string stderr, stri`
`73`	`77`	`}`
`74`	`78`
`75`	`79`	`public AndConstraint<CliResultAssertions> NotHaveStderr(string because = "", params object[] becauseArgs)`
`76`		`- => HaveStderr("", because, becauseArgs);`
	`80`	`+ {`
	`81`	`+ Subject.Stderr.Should().BeEmpty(because, becauseArgs);`
	`82`	`+`
	`83`	`+ return new(this);`
	`84`	`+ }`
`77`	`85`
`78`	`86`	`public AndConstraint<CliResultAssertions> HaveCompileError(string? errorCode = null, string because = "", params object[] becauseArgs)`
`79`	`87`	`{`