Fix regression that broke UNC path handling (#17902)

With `IOUri`, I had intentionally dropped UNC path support, assuming
that it wouldn't to be needed because it's Windows specific. However,
this support turns out to be essential when invoking the Windows version
of Bicep from WSL, since resolved file paths are UNC paths (e.g.,
\\wsl.localhost\Ubuntu-22.04\home\main.bicep). This PR restores UNC path
support for `IOUri`.

Closes #17843.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/17902)

Author: shenglol

src/Bicep.Cli.IntegrationTests/BuildCommandTests.cs

@@ -83,7 +83,7 @@ public async Task Build_Valid_SingleFile_WithTemplateSpecReference_ShouldSucceed
                 // ensure something got restored
 
                 settings.FeatureOverrides!.CacheRootDirectory!.Exists().Should().BeTrue();
-                Directory.EnumerateFiles(settings.FeatureOverrides.CacheRootDirectory!.Uri.GetLocalFilePath(), "*.json", SearchOption.AllDirectories).Should().NotBeEmpty();
+                Directory.EnumerateFiles(settings.FeatureOverrides.CacheRootDirectory!.Uri.GetFilePath(), "*.json", SearchOption.AllDirectories).Should().NotBeEmpty();
             }
 
             var compiledFilePath = Path.Combine(outputDirectory, DataSet.TestFileMainCompiled);

src/Bicep.Cli.IntegrationTests/RestoreCommandTests.cs

@@ -122,7 +122,7 @@ await RegistryHelper.PublishModuleToRegistryAsync(
                 fileSystem.Directory.SetCurrentDirectory(outputPath);
             }
 
-            var cacheRoot = fileExplorer.GetDirectory(IOUri.FromLocalFilePath(outputPath));
+            var cacheRoot = fileExplorer.GetDirectory(IOUri.FromFilePath(outputPath));
 
             var (output, error, result) = await Bicep(
                 services => services
@@ -260,7 +260,7 @@ public async Task Restore_Artifacts_BackwardsAndForwardsCompatibility(string? me
             var restoredFile = cacheRootDirectory.GetFile("restored.bicep");
             restoredFile.Write(bicep);
 
-            var restoredFilePath = restoredFile.Uri.GetLocalFilePath();
+            var restoredFilePath = restoredFile.Uri.GetFilePath();
             var settings = new InvocationSettings(new(TestContext, RegistryEnabled: true), clientFactory.Object, BicepTestConstants.TemplateSpecRepositoryFactory);
 
             var (output, error, result) = await Bicep(settings, "restore", restoredFilePath);
@@ -340,7 +340,7 @@ public async Task Restore_Artifacts_LayerMediaTypes(string[] layerMediaTypes, st
             var restoredFile = cacheRootDirectory.GetFile("restored.bicep");
             restoredFile.Write(bicep);
 
-            var restoredFilePath = restoredFile.Uri.GetLocalFilePath();
+            var restoredFilePath = restoredFile.Uri.GetFilePath();
 
             var settings = new InvocationSettings(new(TestContext, RegistryEnabled: true), clientFactory.Object, BicepTestConstants.TemplateSpecRepositoryFactory);
 

src/Bicep.Cli.UnitTests/Arguments/InputOutputArgumentsResolverTests.cs

@@ -132,7 +132,7 @@ public void PathToUri_should_accept_backslash_paths_on_windows(string windowsPat
 
         // Assert
         result.Should().NotBeNull();
-        result.IsLocalFile.Should().BeTrue();
+        result.IsFile.Should().BeTrue();
         mockPath.Verify(p => p.GetFullPath(windowsPath), Times.Once);
     }
 #endif
@@ -156,7 +156,7 @@ public void PathToUri_should_accept_slash_on_all_platforms(string path)
 
         // Assert
         result.Should().NotBeNull();
-        result.IsLocalFile.Should().BeTrue();
+        result.IsFile.Should().BeTrue();
         mockPath.Verify(p => p.GetFullPath(path), Times.Once);
     }
 }

src/Bicep.Cli/Arguments/InputOutputArgumentsResolver.cs

@@ -24,7 +24,7 @@ public IOUri PathToUri(string path)
                 throw new CommandLineException(string.Format(CliResources.FilePathContainsBackslash, path));
             }
 
-            return IOUri.FromLocalFilePath(GetFullPath(path));
+            return IOUri.FromFilePath(GetFullPath(path));
         }
 
         public IOUri ResolveInputArguments(IInputArguments arguments)
@@ -84,7 +84,7 @@ public IReadOnlyList<IOUri> ResolveFilePatternInputArguments(IFilePatternInputAr
                 foreach (var inputRelativePath in inputRelativePaths)
                 {
                     var inputUri = rootUri.Resolve(inputRelativePath);
-                    var outputRootPath = arguments.OutputDir ?? rootUri.GetLocalFilePath();
+                    var outputRootPath = arguments.OutputDir ?? rootUri.GetFilePath();
                     var outputRelativePath = this.fileSystem.Path.ChangeExtension(inputRelativePath, T.OutputFileExtensionResolver.Invoke(arguments, inputUri));
                     var outputPath = this.fileSystem.Path.Combine(outputRootPath, outputRelativePath);
                     var outputUri = this.PathToUri(outputPath);
@@ -122,15 +122,15 @@ private IOUri ResolveOutputUri(IOUri inputUri, string? outputDir, string? output
         private (IOUri rootUri, IReadOnlyList<string> relativePaths) ResolveFilePattern(string filePattern)
         {
             var (rootPath, relativePattern) = SplitFilePatternOnWildcard(filePattern);
-            var rootUri = IOUri.FromLocalFilePath(rootPath);
+            var rootUri = IOUri.FromFilePath(rootPath);
 
             Matcher matcher = new();
             matcher.AddInclude(relativePattern);
 
             var relativePaths = new List<string>();
             foreach (var filePath in matcher.GetResultsInFullPath(rootPath))
             {
-                var fileUri = IOUri.FromLocalFilePath(filePath);
+                var fileUri = IOUri.FromFilePath(filePath);
                 var relativePath = fileUri.GetPathRelativeTo(rootUri);
                 relativePaths.Add(relativePath);
             }

src/Bicep.Cli/Commands/PublishExtensionCommand.cs

@@ -182,13 +182,13 @@ private async Task<IFileHandle> GetTypesFromExtension(IOUri binaryUri, Cancellat
 
             var fileExplorer = new InMemoryFileExplorer();
 
-            var indexUri = IOUri.FromLocalFilePath("/index.json");
+            var indexUri = IOUri.FromFilePath("/index.json");
             var indexHandle = fileExplorer.GetFile(indexUri);
             indexHandle.Write(typeFiles.IndexFileContent);
 
             foreach (var (path, content) in typeFiles.TypeFileContents)
             {
-                var fileUri = IOUri.FromLocalFilePath($"/{path}");
+                var fileUri = IOUri.FromFilePath($"/{path}");
                 fileExplorer.GetFile(fileUri).Write(content);
             }
 

src/Bicep.Cli/Commands/SnapshotCommand.cs

@@ -132,7 +132,7 @@ private Snapshot ReadSnapshot(IOUri uri)
         if (!file.TryReadAllText().IsSuccess(out var contents, out var failureBuilder))
         {
             var message = failureBuilder(DiagnosticBuilder.ForDocumentStart()).Message;
-            throw new CommandLineException($"Error opening file {uri.GetLocalFilePath()}: {message}.");
+            throw new CommandLineException($"Error opening file {uri.GetFilePath()}: {message}.");
         }
 
         return SnapshotHelper.Deserialize(contents);

src/Bicep.Cli/Rpc/CliJsonRpcServer.cs

@@ -111,7 +111,7 @@ public async Task<GetFileReferencesResponse> GetFileReferences(GetFileReferences
         }
 
         return new(
-            [.. fileUris.Select(x => x.GetLocalFilePath()).OrderBy(x => x)]);
+            [.. fileUris.Select(x => x.GetFilePath()).OrderBy(x => x)]);
     }
 
     /// <inheritdoc/>

src/Bicep.Core.UnitTests/Registry/CachedModules.cs

@@ -22,7 +22,7 @@ public static class CachedModules
     // Get all cached modules from the local on-disk registry cache
     public static ImmutableArray<CachedModule> GetCachedModules(IFileSystem fileSystem, IDirectoryHandle cacheRootDirectory)
     {
-        var cacheDir = fileSystem.DirectoryInfo.New(cacheRootDirectory.Uri.GetLocalFilePath());
+        var cacheDir = fileSystem.DirectoryInfo.New(cacheRootDirectory.Uri.GetFilePath());
         if (!cacheDir.Exists)
         {
             return [];

src/Bicep.Core.UnitTests/Registry/OciModuleRegistryTests.cs

@@ -742,7 +742,7 @@ private OciArtifactReference CreateModuleReference(BicepSourceFile referencingFi
             var parentModuleUri = new Uri(bicepPath);
 
             var featureProviderMock = StrictMock.Of<IFeatureProvider>();
-            var cacheRootDirectory = BicepTestConstants.FileExplorer.GetDirectory(IOUri.FromLocalFilePath(TestOutputPath));
+            var cacheRootDirectory = BicepTestConstants.FileExplorer.GetDirectory(IOUri.FromFilePath(TestOutputPath));
             featureProviderMock.Setup(m => m.CacheRootDirectory).Returns(cacheRootDirectory);
 
             var featureProviderFactoryMock = StrictMock.Of<IFeatureProviderFactory>();

src/Bicep.Core.UnitTests/Utils/FileHelper.cs

@@ -83,7 +83,7 @@ public static string SaveEmbeddedResourcesWithPathPrefix(TestContext testContext
         public static IDirectoryHandle GetCacheRootDirectory(TestContext testContext)
         {
             var path = GetUniqueTestOutputPath(testContext);
-            var uri = IOUri.FromLocalFilePath(path);
+            var uri = IOUri.FromFilePath(path);
 
             return BicepTestConstants.FileExplorer.GetDirectory(uri);
         }