fix and add test for invalid parameter type (#17193)

Fixes #16731 

Adding diagnostic error when there is a type mismatch between the
parameter in the bicep file and the parameter in the bicepparam file.

Also adding a test to verify the error message is correct

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/17193)

Author: polatengin

src/Bicep.Cli.IntegrationTests/BuildParamsCommandTests.cs

@@ -645,5 +645,67 @@ param intParam int
                 File.Exists(Path.Combine(bicepOutputPath, outputFile)).Should().Be(true, f);
             }
         }
+
+        [TestMethod]
+        public async Task BuildParams_Extends_InvalidType_ThrowsError()
+        {
+            var outputPath = FileHelper.GetUniqueTestOutputPath(TestContext);
+            FileHelper.SaveResultFile(TestContext, "main.bicep", @"
+            param tag string
+            ", outputPath);
+            FileHelper.SaveResultFile(TestContext, "base.bicepparam", @"
+            using none
+            param tag = 42
+            ", outputPath);
+            var inputFile = FileHelper.SaveResultFile(TestContext, "main.bicepparam", @"
+            using 'main.bicep'
+            extends 'base.bicepparam'
+            ", outputPath);
+
+            var expectedOutputFile = FileHelper.GetResultFilePath(TestContext, "main.json", outputPath);
+            File.Exists(expectedOutputFile).Should().BeFalse();
+
+            var (output, error, result) = await Bicep(["build-params", inputFile]);
+
+            File.Exists(expectedOutputFile).Should().BeFalse();
+
+            output.Should().BeEmpty();
+            error.Should().Contain("Error BCP033: Expected a value of type \"string\" but the provided value is of type \"42\".");
+            result.Should().Be(1);
+        }
+
+        [TestMethod]
+        public async Task BuildParams_Extends_Multiple_InvalidType_ThrowsMultipleErrors()
+        {
+            var outputPath = FileHelper.GetUniqueTestOutputPath(TestContext);
+            FileHelper.SaveResultFile(TestContext, "main.bicep", @"
+            param myString string
+            param myInt int
+            param myBool bool
+            ", outputPath);
+            FileHelper.SaveResultFile(TestContext, "base.bicepparam", @"
+            using none
+            param myInt = '42'
+            param myString = {}
+            param myBool = []
+            ", outputPath);
+            var inputFile = FileHelper.SaveResultFile(TestContext, "main.bicepparam", @"
+            using './main.bicep'
+            extends 'base.bicepparam'
+            ", outputPath);
+
+            var expectedOutputFile = FileHelper.GetResultFilePath(TestContext, "main.json", outputPath);
+            File.Exists(expectedOutputFile).Should().BeFalse();
+
+            var (output, error, result) = await Bicep(["build-params", inputFile]);
+
+            File.Exists(expectedOutputFile).Should().BeFalse();
+
+            output.Should().BeEmpty();
+            error.Should().Contain("Error BCP033: Expected a value of type \"int\" but the provided value is of type \"'42'\".");
+            error.Should().Contain("Error BCP033: Expected a value of type \"string\" but the provided value is of type \"object\".");
+            error.Should().Contain("Error BCP033: Expected a value of type \"bool\" but the provided value is of type \"<empty array>\".");
+            result.Should().Be(1);
+        }
     }
 }

src/Bicep.Core/Semantics/SemanticModel.cs

@@ -700,17 +700,30 @@ private IEnumerable<IDiagnostic> GatherMissingRequiredExtensionConfigAssignmentD
 
         private IEnumerable<IDiagnostic> GatherTypeMismatchDiagnostics()
         {
-            foreach (var assignmentSymbol in Root.ParameterAssignments.Where(x => x.Context.SourceFile == Root.Context.SourceFile))
+            foreach (var assignmentSymbol in Root.ParameterAssignments)
             {
+                var isFromSameFile = assignmentSymbol.Context.SourceFile == Root.Context.SourceFile;
+
                 if (assignmentSymbol.Type is not ErrorType &&
                     assignmentSymbol.Type is not NullType && // `param x = null` is equivalent to skipping the assignment altogether
                     TypeManager.GetDeclaredType(assignmentSymbol.DeclaringSyntax) is { } declaredType)
                 {
-                    var diagnostics = ToListDiagnosticWriter.Create();
-                    TypeValidator.NarrowTypeAndCollectDiagnostics(TypeManager, Binder, ParsingErrorLookup, diagnostics, assignmentSymbol.DeclaringParameterAssignment.Value, declaredType);
-                    foreach (var diagnostic in diagnostics.GetDiagnostics())
+                    if (isFromSameFile)
+                    {
+                        var diagnostics = ToListDiagnosticWriter.Create();
+                        TypeValidator.NarrowTypeAndCollectDiagnostics(TypeManager, Binder, ParsingErrorLookup, diagnostics, assignmentSymbol.DeclaringParameterAssignment.Value, declaredType);
+                        foreach (var diagnostic in diagnostics.GetDiagnostics())
+                        {
+                            yield return diagnostic;
+                        }
+                    }
+                    else
                     {
-                        yield return diagnostic;
+                        var areTypesAssignable = TypeValidator.AreTypesAssignable(assignmentSymbol.Type, declaredType);
+                        if (!areTypesAssignable)
+                        {
+                            yield return DiagnosticBuilder.ForPosition(assignmentSymbol.DeclaringSyntax).ExpectedValueTypeMismatch(false, declaredType, assignmentSymbol.Type);
+                        }
                     }
                 }
             }