Remove onlyIfNotExists experimental feature (#17996)

## Description

Remove onlyIfNotExists experimental feature to make decorator GA.

Updated EmitterSettings.cs to emit template language 2.0 when
onlyIfNotExists() decorator is used.

## Checklist

- [X] I have read and adhere to the [contribution
guide](https://github.com/Azure/bicep/blob/main/CONTRIBUTING.md).

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/17996)

Author: tsmallig33

docs/experimental-features.md

@@ -38,19 +38,6 @@ Enables Bicep to run deployments locally, so that you can run Bicep extensions w
 Moves defining extension configurations to the module level rather than from within a template. The feature also
 includes enhancements for Deployment stacks extensibility integration. This feature is not ready for use.
 
-### `onlyIfNotExists`
-The feature introduces the onlyIfNotExists decorator on a resource. The decorator will only deploy the resource if it does not exist. (Note: This feature will not work until the backend service support has been deployed)
-```
-@onlyIfNotExists()
-resource onlyDeployIfNotExists 'Microsoft...' = {
-  name: 'example'
-  location: 'eastus'
-  properties: {
-    ...
-  }
-}
-```
-
 ### `resourceInfoCodegen`
 
 Enables the 'resourceInfo' function for simplified code generation.

src/Bicep.Core.IntegrationTests/Decorators/OnlyIfNotExistsDecoratorTests.cs

@@ -23,7 +23,7 @@ public class OnlyIfNotExistsDecoratorTests
         [TestMethod]
         public void OnlyIfNotExistsDecorator_ValidScenario()
         {
-            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, OnlyIfNotExistsEnabled: true));
+            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext));
             var (template, diagnostics, _) = CompilationHelper.Compile(services, @"
             @onlyIfNotExists()
             resource sqlServer 'Microsoft.Sql/servers@2021-11-01' = {
@@ -40,13 +40,15 @@ public void OnlyIfNotExistsDecorator_ValidScenario()
 
                 template.Should().NotBeNull()
                     .And.HaveValueAtPath("$.resources['sqlServer'][email protected]", onlyIfNotExistsJObject);
+                template.Should().NotBeNull()
+                    .And.HaveValueAtPath("$.languageVersion", "2.0");
             }
         }
 
         [TestMethod]
         public void OnlyIfNotExistsAndRetryOnDecorator_ValidScenario()
         {
-            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, OnlyIfNotExistsEnabled: true, WaitAndRetryEnabled: true));
+            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, WaitAndRetryEnabled: true));
             var (template, diagnostics, _) = CompilationHelper.Compile(services, @"
             @onlyIfNotExists()
             @retryOn(['ResourceNotFound', 'ServerError'], 1)
@@ -79,7 +81,7 @@ public void OnlyIfNotExistsAndRetryOnDecorator_ValidScenario()
         [TestMethod]
         public void OnlyIfNotExistsDecorator_WithModuleDeclaration_ShouldFail()
         {
-            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, OnlyIfNotExistsEnabled: true));
+            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext));
 
             var mainUri = new Uri("file:///main.bicep");
             var moduleUri = new Uri("file:///module.bicep");
@@ -119,7 +121,7 @@ param inputb string
         [TestMethod]
         public void OnlyIfNotExistsDecorator_ExpectedResourceDeclaration()
         {
-            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, OnlyIfNotExistsEnabled: true));
+            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext));
             var (template, diagnostics, _) = CompilationHelper.Compile(services, @"
             @onlyIfNotExists()
             ");
@@ -135,7 +137,7 @@ public void OnlyIfNotExistsDecorator_ExpectedResourceDeclaration()
         [TestMethod]
         public void OnlyIfNotExistsDecoratorWithCollections_ValidScenario()
         {
-            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, OnlyIfNotExistsEnabled: true));
+            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext));
             var (template, diagnostics, _) = CompilationHelper.Compile(services, @"
             @onlyIfNotExists()
             resource sqlServer 'Microsoft.Sql/servers@2021-11-01' = [for i in range(1, 2):{
@@ -157,26 +159,6 @@ public void OnlyIfNotExistsDecoratorWithCollections_ValidScenario()
 
         [TestMethod]
         public void OnlyIfNotExistsDecorator_Arguments_ShouldFail()
-        {
-            var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext, OnlyIfNotExistsEnabled: true));
-            var (template, diagnostics, _) = CompilationHelper.Compile(services, @"
-            @onlyIfNotExists(1)
-            resource sqlServer 'Microsoft.Sql/servers@2021-11-01' = {
-                name: 'sql-server-name'
-                location: 'polandcentral'
-            }
-            ");
-            using (new AssertionScope())
-            {
-                template.Should().NotHaveValue();
-                diagnostics.ExcludingLinterDiagnostics().Should().HaveDiagnostics(new[] {
-                    ("BCP071", DiagnosticLevel.Error, "Expected 0 arguments, but got 1."),
-                });
-            }
-        }
-
-        [TestMethod]
-        public void OnlyIfNotExistsDecorator_NotEnabled_ShouldFail()
         {
             var services = new ServiceBuilder().WithFeatureOverrides(new FeatureProviderOverrides(TestContext));
             var (template, diagnostics, _) = CompilationHelper.Compile(services, @"
@@ -190,7 +172,7 @@ public void OnlyIfNotExistsDecorator_NotEnabled_ShouldFail()
             {
                 template.Should().NotHaveValue();
                 diagnostics.ExcludingLinterDiagnostics().Should().HaveDiagnostics(new[] {
-                    ("BCP057", DiagnosticLevel.Error, "The name \"onlyIfNotExists\" does not exist in the current context."),
+                    ("BCP071", DiagnosticLevel.Error, "Expected 0 arguments, but got 1."),
                 });
             }
         }

src/Bicep.Core.Samples/Files/baselines/InvalidOutputs_CRLF/Completions/decorators.json

@@ -205,6 +205,23 @@
       "command": "editor.action.triggerParameterHints"
     }
   },
+  {
+    "label": "onlyIfNotExists",
+    "kind": "function",
+    "documentation": {
+      "kind": "markdown",
+      "value": "```bicep\nonlyIfNotExists(): any\n\n```  \n  \n"
+    },
+    "deprecated": false,
+    "preselect": false,
+    "sortText": "3_onlyIfNotExists",
+    "insertTextFormat": "snippet",
+    "insertTextMode": "adjustIndentation",
+    "textEdit": {
+      "range": {},
+      "newText": "onlyIfNotExists()$0"
+    }
+  },
   {
     "label": "sealed",
     "kind": "function",

src/Bicep.Core.Samples/Files/baselines/InvalidOutputs_CRLF/Completions/decoratorsPlusNamespace.json

@@ -205,6 +205,23 @@
       "command": "editor.action.triggerParameterHints"
     }
   },
+  {
+    "label": "onlyIfNotExists",
+    "kind": "function",
+    "documentation": {
+      "kind": "markdown",
+      "value": "```bicep\nonlyIfNotExists(): any\n\n```  \n  \n"
+    },
+    "deprecated": false,
+    "preselect": false,
+    "sortText": "3_onlyIfNotExists",
+    "insertTextFormat": "snippet",
+    "insertTextMode": "adjustIndentation",
+    "textEdit": {
+      "range": {},
+      "newText": "onlyIfNotExists()$0"
+    }
+  },
   {
     "label": "sealed",
     "kind": "function",

src/Bicep.Core.UnitTests/Configuration/ConfigurationManagerTests.cs

@@ -111,7 +111,6 @@ public void GetBuiltInConfiguration_NoParameter_ReturnsBuiltInConfigurationWithA
           "localDeploy": false,
           "resourceInfoCodegen": false,
           "desiredStateConfiguration": false,
-          "onlyIfNotExists": false,
           "userDefinedConstraints": false,
           "deployCommands": false
         },
@@ -195,7 +194,6 @@ public void GetBuiltInConfiguration_DisableAllAnalyzers_ReturnsBuiltInConfigurat
           "resourceInfoCodegen": false,
           "moduleExtensionConfigs": false,
           "desiredStateConfiguration": false,
-          "onlyIfNotExists": false,
           "userDefinedConstraints": false,
           "deployCommands": false
         },
@@ -301,7 +299,6 @@ public void GetBuiltInConfiguration_DisableAnalyzers_ReturnsBuiltInConfiguration
           "resourceInfoCodegen": false,
           "moduleExtensionConfigs": false,
           "desiredStateConfiguration": false,
-          "onlyIfNotExists": false,
           "userDefinedConstraints": false,
           "deployCommands": false
         },
@@ -388,7 +385,6 @@ public void GetBuiltInConfiguration_EnableExperimentalFeature_ReturnsBuiltInConf
                 ResourceInfoCodegen: false,
                 ModuleExtensionConfigs: false,
                 DesiredStateConfiguration: false,
-                OnlyIfNotExists: false,
                 UserDefinedConstraints: false,
                 DeployCommands: false);
 
@@ -473,7 +469,6 @@ public void GetBuiltInConfiguration_EnableExperimentalFeature_ReturnsBuiltInConf
                 "resourceInfoCodegen": false,
                 "moduleExtensionConfigs": false,
                 "desiredStateConfiguration": false,
-                "onlyIfNotExists": false,
                 "userDefinedConstraints": false,
                 "deployCommands": false
             },
@@ -825,7 +820,6 @@ public void GetConfiguration_ValidCustomConfiguration_OverridesBuiltInConfigurat
                     "resourceInfoCodegen": false,
                     "moduleExtensionConfigs": false,
                     "desiredStateConfiguration": false,
-                    "onlyIfNotExists": false,
                     "userDefinedConstraints": false,
                     "deployCommands": false
                   },

src/Bicep.Core.UnitTests/Features/FeatureProviderOverrides.cs

@@ -24,7 +24,6 @@ public record FeatureProviderOverrides(
     string? AssemblyVersion = BicepTestConstants.DevAssemblyFileVersion,
     bool? ModuleExtensionConfigsEnabled = default,
     bool? DesiredStateConfigurationEnabled = default,
-    bool? OnlyIfNotExistsEnabled = default,
     bool? UserDefinedConstraintsEnabled = default,
     bool? DeployCommandsEnabled = default)
 {
@@ -45,7 +44,6 @@ public FeatureProviderOverrides(
         string? AssemblyVersion = BicepTestConstants.DevAssemblyFileVersion,
         bool? ModuleExtensionConfigsEnabled = default,
         bool? DesiredStateConfigurationEnabled = default,
-        bool? OnlyIfNotExistsEnabled = default,
         bool? UserDefinedConstraintsEnabled = default,
         bool? DeployCommandsEnabled = default) : this(
             FileHelper.GetCacheRootDirectory(testContext),
@@ -64,7 +62,6 @@ public FeatureProviderOverrides(
             AssemblyVersion,
             ModuleExtensionConfigsEnabled,
             DesiredStateConfigurationEnabled,
-            OnlyIfNotExistsEnabled,
             UserDefinedConstraintsEnabled,
             DeployCommandsEnabled)
     { }

src/Bicep.Core.UnitTests/Features/OverriddenFeatureProvider.cs

@@ -35,8 +35,6 @@ public OverriddenFeatureProvider(IFeatureProvider features, FeatureProviderOverr
 
     public bool WaitAndRetryEnabled => overrides.WaitAndRetryEnabled ?? features.WaitAndRetryEnabled;
 
-    public bool OnlyIfNotExistsEnabled => overrides.OnlyIfNotExistsEnabled ?? features.OnlyIfNotExistsEnabled;
-
     public bool LocalDeployEnabled => overrides.LocalDeployEnabled ?? features.LocalDeployEnabled;
 
     public bool ResourceInfoCodegenEnabled => overrides.ResourceInfoCodegenEnabled ?? features.ResourceInfoCodegenEnabled;

src/Bicep.Core/Configuration/ExperimentalFeaturesEnabled.cs

@@ -22,7 +22,6 @@ public record ExperimentalFeaturesEnabled(
     bool ResourceInfoCodegen,
     bool ModuleExtensionConfigs,
     bool DesiredStateConfiguration,
-    bool OnlyIfNotExists,
     bool UserDefinedConstraints,
     bool DeployCommands)
 {
@@ -44,7 +43,6 @@ public static ExperimentalFeaturesEnabled Bind(JsonElement element)
         ResourceInfoCodegen: false,
         ModuleExtensionConfigs: false,
         DesiredStateConfiguration: false,
-        OnlyIfNotExists: false,
         UserDefinedConstraints: false,
         DeployCommands: false);
 }

src/Bicep.Core/CoreResources.Designer.cs

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!--
-    Microsoft ResX Schema
-
+  <!-- 
+    Microsoft ResX Schema 
+    
     Version 2.0
-
-    The primary goals of this format is to allow a simple XML format
-    that is mostly human readable. The generation and parsing of the
-    various data types are done through the TypeConverter classes
+    
+    The primary goals of this format is to allow a simple XML format 
+    that is mostly human readable. The generation and parsing of the 
+    various data types are done through the TypeConverter classes 
     associated with the data types.
-
+    
     Example:
-
+    
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-
-    There are any number of "resheader" rows that contain simple
+                
+    There are any number of "resheader" rows that contain simple 
     name/value pairs.
-
-    Each data row contains a name, and value. The row also contains a
-    type or mimetype. Type corresponds to a .NET class that support
-    text/value conversion through the TypeConverter architecture.
-    Classes that don't support this are serialized and stored with the
+    
+    Each data row contains a name, and value. The row also contains a 
+    type or mimetype. Type corresponds to a .NET class that support 
+    text/value conversion through the TypeConverter architecture. 
+    Classes that don't support this are serialized and stored with the 
     mimetype set.
-
-    The mimetype is used for serialized objects, and tells the
-    ResXResourceReader how to depersist the object. This is currently not
+    
+    The mimetype is used for serialized objects, and tells the 
+    ResXResourceReader how to depersist the object. This is currently not 
     extensible. For a given mimetype the value must be set accordingly:
-
-    Note - application/x-microsoft.net.object.binary.base64 is the format
-    that the ResXResourceWriter will generate, however the reader can
+    
+    Note - application/x-microsoft.net.object.binary.base64 is the format 
+    that the ResXResourceWriter will generate, however the reader can 
     read any of the formats listed below.
-
+    
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with
+    value   : The object must be serialized with 
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-
+    
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with
+    value   : The object must be serialized with 
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array
+    value   : The object must be serialized into a byte array 
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -529,9 +529,6 @@
     <value>Parameter '{0}' is used as a resource identifier, API version, or condition in the module '{1}'. Providing a runtime value for this parameter will lead to short-circuiting or less precise predictions in What-If.</value>
     <comment>{0} Parameter name</comment>
   </data>
-  <data name="ExperimentalFeatureNames_OnlyIfNotExists" xml:space="preserve">
-    <value>Enable OnlyIfNotExists feature</value>
-  </data>
   <data name="ImportMustBeUsedRuleDescription" xml:space="preserve">
     <value>All imports must be used.</value>
   </data>
@@ -553,4 +550,4 @@
   <data name="StacksExtensibilityCompatibilityRule_NonSecurePropertyValueIsReference" xml:space="preserve">
     <value>Non-secure config property values must be a value type to be valid for Deployment stack deployments.</value>
   </data>
-</root>
+</root>