Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility - input enrichers #313

Open
voltcode opened this issue Mar 22, 2019 · 1 comment
Open

Extensibility - input enrichers #313

voltcode opened this issue Mar 22, 2019 · 1 comment
Labels
new-feature New feature requests

Comments

@voltcode
Copy link

Scenario:
I tried extending the pipeline with System.Web.HttpContext.Current (NET FX) information on event creation in something like log4net input.
This is currently a problem, because filters execute without context information (I assume this is because of TPL DataFlow setup), so the initial context is lost.
Moreover, System.Web.HttpContext is NET FX specific, so instead of having a netstandard-based log4net input, and an NET FX-specific input filter that would execute on the same thread with all context information as log4net appender.

I know with log4net, one can hook into global.asax's events, and add ThreadContext information, but I think it is bad design - it scatters data enrichment all over the code (HttpContext is just one type of information).

I suppose one could hack their own inputs, based on existing ones, but that goes against composability.

I see great opportunity in input enrichers, because you could also add domain-specific information more easily for ingest by output receivers like AI, without having a dedicated log4net input, that differs per application. Adding domain-specific information to events speeds up investigations by A LOT :)

@karolz-ms karolz-ms added the new-feature New feature requests label Mar 22, 2019
@karolz-ms
Copy link
Collaborator

Yes, thank you, this is a great idea and a feature missing from EventFlow today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature requests
Projects
None yet
Development

No branches or pull requests

2 participants