Skip to content

Commit 8d28588

Browse files
authored
Fix sender sending to errChan twice (#156)
* we should return in the goroutine after an error * change to use else
1 parent cd2cf51 commit 8d28588

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: v2/sender.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ func (d *Sender) SendMessage(ctx context.Context, mb MessageBody, options ...fun
7272
go func() {
7373
if err := d.sbSender.SendMessage(ctx, msg, nil); err != nil { // sendMessageOptions currently does nothing
7474
errChan <- fmt.Errorf("failed to send message: %w", err)
75+
} else {
76+
errChan <- nil
7577
}
76-
errChan <- nil
7778
}()
7879

7980
select {
@@ -142,8 +143,9 @@ func (d *Sender) SendMessageBatch(ctx context.Context, messages []*azservicebus.
142143
go func() {
143144
if err := d.sbSender.SendMessageBatch(ctx, batch, nil); err != nil {
144145
errChan <- fmt.Errorf("failed to send message batch: %w", err)
146+
} else {
147+
errChan <- nil
145148
}
146-
errChan <- nil
147149
}()
148150

149151
select {

0 commit comments

Comments
 (0)