'in' operator is less robust than other options for deriving key presence

[Packmanager9]

Problem:
Given that the 'in' operator will throw an error error and fail: 'Cannot use 'in' operator to search for 'top' in 1'
(Line 4959 in 'msRest.node.js)

Solution
A different method of deriving the key presence could be used.

Original:

  if (parent != undefined && parameterPathPart in parent) {
      parent = parent[parameterPathPart];
  }

Proposed:

  if (parent != undefined && Object.keys(parent).includes(parameterPathPart)) {
      parent = parent[parameterPathPart];
  } 

Alternatives:
Tried removing the check all together, immediately fails.

[jeremymeng]

@Packmanager9 The current code assumes that parent is an object, but the error indicates that it could be a primitive type. Do you have some simplified repro?

ms-rest-js/lib/serviceClient.ts

Lines 721 to 731 in 386ed0f

	function getPropertyFromParameterPath(
	parent: { [parameterName: string]: any },
	parameterPath: string[]
	): PropertySearchResult {
	const result: PropertySearchResult = { propertyFound: false };
	let i = 0;
	for (; i < parameterPath.length; ++i) {
	const parameterPathPart: string = parameterPath[i];
	// Make sure to check inherited properties too, so don't use hasOwnProperty().
	if (parent != undefined && parameterPathPart in parent) {
	parent = parent[parameterPathPart];

The only call to this method is on a serviceClient which should be an object.

ms-rest-js/lib/serviceClient.ts

Lines 663 to 664 in 386ed0f

	propertySearchResult = getPropertyFromParameterPath(serviceClient, parameterPath);
	}

[Packmanager9]

Sure, here's the snippet I was using.

msRestNodeAuth.interactiveLogin().then((creds) => {
const client = new LogicManagementClient(creds, subscriptionId);
const top = 1;
const filter = "testfilter";
client.workflows.listBySubscription(top, filter).then((result) => {
console.log("The result is:");
console.log(result);
});
}).catch((err) => {
console.error(err);
});

[jeremymeng]

@Packmanager9 could you please try wrapping the arguments to listBySubscription with an object?

-client.workflows.listBySubscription(top, filter)
+client.workflows.listBySubscription({top, filter})

The method expects an options object

  listBySubscription(options?: Models.WorkflowsListBySubscriptionOptionalParams): Promise<Models.WorkflowsListBySubscriptionResponse>;

[jeremymeng]

@Packmanager9 it's been a while, have you got a chance to look at the above suggestion?