From d22be1de91cff789f5c25b47d8c045fbdcbbbf59 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Tue, 14 Nov 2023 16:44:30 +0800 Subject: [PATCH 1/5] Fix 301-machine-learning-hub-spoke-secure --- quickstart/301-machine-learning-hub-spoke-secure/main.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/quickstart/301-machine-learning-hub-spoke-secure/main.tf b/quickstart/301-machine-learning-hub-spoke-secure/main.tf index 074cec954..162f55f9b 100644 --- a/quickstart/301-machine-learning-hub-spoke-secure/main.tf +++ b/quickstart/301-machine-learning-hub-spoke-secure/main.tf @@ -8,7 +8,7 @@ terraform { } azureml = { - source = "registry.terraform.io/Telemaco019/azureml" + source = "registry.terraform.io/orobix/azureml" } } } @@ -29,4 +29,4 @@ resource "azurerm_resource_group" "hub_rg" { name = "rg-hub-${var.name}-${var.environment}" location = var.location -} \ No newline at end of file +} From 1c87d07e50929b71416963963d6726370d069765 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Wed, 15 Nov 2023 11:25:29 +0800 Subject: [PATCH 2/5] update code --- quickstart/301-machine-learning-hub-spoke-secure/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickstart/301-machine-learning-hub-spoke-secure/main.tf b/quickstart/301-machine-learning-hub-spoke-secure/main.tf index 162f55f9b..cdafd5ea3 100644 --- a/quickstart/301-machine-learning-hub-spoke-secure/main.tf +++ b/quickstart/301-machine-learning-hub-spoke-secure/main.tf @@ -4,7 +4,7 @@ terraform { required_providers { azurerm = { source = "hashicorp/azurerm" - version = "=2.78.0" + version = ">=2.78.0" } azureml = { From 8e043824c62784be4e2cc63ed6d7803fb40a9750 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Wed, 15 Nov 2023 11:31:52 +0800 Subject: [PATCH 3/5] update code --- .../301-machine-learning-hub-spoke-secure/azure-firewall.tf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf b/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf index 6293ab1cb..20d61d9f6 100644 --- a/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf +++ b/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf @@ -48,6 +48,8 @@ resource "azurerm_firewall" "azure_firewall_instance" { location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.hub_rg.name firewall_policy_id = azurerm_firewall_policy.base_policy.id + sku_name = "AZFW_Hub" + sku_tier = "Standard" ip_configuration { name = "configuration" @@ -487,4 +489,4 @@ resource "azurerm_firewall_policy_rule_collection_group" "azure_firewall_rules_c azurerm_ip_group.ip_group_hub, azurerm_ip_group.ip_group_spoke ] -} \ No newline at end of file +} From 5df4e97fe48e7f0a665ded695e3f9e13f649a490 Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Wed, 15 Nov 2023 11:32:56 +0800 Subject: [PATCH 4/5] update code --- .../301-machine-learning-hub-spoke-secure/azure-firewall.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf b/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf index 20d61d9f6..dd19174d5 100644 --- a/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf +++ b/quickstart/301-machine-learning-hub-spoke-secure/azure-firewall.tf @@ -48,7 +48,7 @@ resource "azurerm_firewall" "azure_firewall_instance" { location = azurerm_resource_group.default.location resource_group_name = azurerm_resource_group.hub_rg.name firewall_policy_id = azurerm_firewall_policy.base_policy.id - sku_name = "AZFW_Hub" + sku_name = "AZFW_VNet" sku_tier = "Standard" ip_configuration { From a7dac1f1cee44647a8068d3df4a7beee0f24ce2f Mon Sep 17 00:00:00 2001 From: neil-yechenwei Date: Thu, 16 Nov 2023 11:15:14 +0800 Subject: [PATCH 5/5] update code --- quickstart/301-machine-learning-hub-spoke-secure/variables.tf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/quickstart/301-machine-learning-hub-spoke-secure/variables.tf b/quickstart/301-machine-learning-hub-spoke-secure/variables.tf index 9618d98c6..d2969abaa 100644 --- a/quickstart/301-machine-learning-hub-spoke-secure/variables.tf +++ b/quickstart/301-machine-learning-hub-spoke-secure/variables.tf @@ -1,6 +1,7 @@ variable "name" { type = string description = "Name of the deployment" + default = "exampleml" } variable "environment" { @@ -89,5 +90,6 @@ variable "dsvm_admin_username" { variable "dsvm_host_password" { type = string description = "Password for the admin username of the Data Science VM" + default = "ChangeMe123!" sensitive = true -} \ No newline at end of file +}