Skip to content

[Internal] IdentityComparer.AreEqual(object object1, object object2) #3130

@pmaytak

Description

@pmaytak

IdentityComparer.AreEqual(object object1, object object2) (without CompareContext) doesn't throw if objects don't match, but only returns a bool. There are usages of this where we don't assert the return value, and thus the test method can succeed when it should've failed.

TODO:

  • Look though all the cases where this method overload is used and probably replace it with the overload that accepts the CompareContext and remove this overload.
  • If it's not possible to remove this overload (there's some valid reason for this to be used), then make sure the result is always asserted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FundamentalsGood First IssueThis is a good item for new team membersInternalIndicates issue was opened by the IdentityModel team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions