Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing portalocker dependency #96

Open
chlowell opened this issue Aug 20, 2021 · 1 comment · May be fixed by #117
Open

Consider removing portalocker dependency #96

chlowell opened this issue Aug 20, 2021 · 1 comment · May be fixed by #117
Labels
enhancement New feature or request

Comments

@chlowell
Copy link
Contributor

Primarily because it requires pywin32, which has been a troublesome (transitive) dependency. See for example these Azure SDK issues:

AssertionError upon importing pywin32 in Azure Function: Azure/azure-sdk-for-python#19989
Can't run python after installing pywin32 226: Azure/azure-sdk-for-python#8573
DLL load fails on Python 3.8: Azure/azure-sdk-for-python#8292
@rayluo rayluo added the enhancement New feature or request label Aug 20, 2021
@rayluo
Copy link
Contributor

rayluo commented Aug 20, 2021 •
edited
Loading

Thanks for providing lots of materials here. We will take a look, and possibly re-open the previous research effort on relevant topics here and there.

Currently, the file locking is the reason we use portalocker, because we do not want to get ourselves into the file locking business. We will need some investigation to see what we can do here.

@rayluo rayluo mentioned this issue Aug 1, 2022
Closed
@rayluo rayluo linked a pull request Sep 17, 2023 that will close this issue
Make portalocker optional #117
Open
@edgarrmondragon edgarrmondragon mentioned this issue Aug 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make portalocker optional AzureAD/microsoft-authentication-extensions-for-python
2 participants
@rayluo @chlowell