Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On product delete, clean challenges.prudctIds if deleted product is whitelisted ? #255

Open
Tirodem opened this issue Jul 5, 2023 · 1 comment
Assignees

Comments

@Tirodem
Copy link
Contributor

Tirodem commented Jul 5, 2023

To keep in mind for potential impacts on challege incrementation on paid order ( #248 )
Use case :

  • I have X products
  • I create a challenge with Y whitelisted products
  • I delete one of the Y whitelisted products

=> What happens on the next paid order ? Do we search for a deleted product ?
Either it's without impact and we keep the entry in challenge.productIds, or it's problematic and we clean challenges on product deletion

@coyotte508
Copy link
Collaborator

Really easy to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants