Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Manage alias duplicate error in front #1016 #1644

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

ithiame
Copy link
Contributor

@ithiame ithiame commented Dec 12, 2024

No description provided.

@ithiame ithiame linked an issue Dec 12, 2024 that may be closed by this pull request
2 tasks
@ithiame ithiame requested a review from coyotte508 December 12, 2024 14:49
@AmadouAgiltoo
Copy link
Contributor

Test OK (test workflow)

Copy link
Collaborator

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should use use:enhance with the form and forward the error (without erasing all the data) in case of error

Instead of fetching the list of all aliases and passing it to the frtonend

@ithiame ithiame requested a review from coyotte508 January 22, 2025 08:46
@AmadouAgiltoo
Copy link
Contributor

It's partially OK.
When an alias already exists for a product line,
if the same alias is entered on another line, the message appears correctly, and the update button is disabled.
However, when the user clears their input to enter something else, sometimes the message remains displayed, and the button stays disabled, forcing them to reload the page.

@AmadouAgiltoo
Copy link
Contributor

The case is not handled either (e.g., pe and Pe).

@AmadouAgiltoo
Copy link
Contributor

PR retested after integrating back-end checks and sending the message from the front-end. It's OK now. The case sensitivity issue will be addressed in another ticket.

@AmadouAgiltoo
Copy link
Contributor

Done !

@AmadouAgiltoo AmadouAgiltoo reopened this Jan 22, 2025
@AmadouAgiltoo AmadouAgiltoo merged commit b5e5773 into main Jan 22, 2025
4 checks passed
@AmadouAgiltoo AmadouAgiltoo deleted the manage-alias-duplicate branch January 22, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Manage alias duplicate error in front
3 participants