Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrunedRelaxedClockModel is broken after meanRate is changed to Function #15

Open
walterxie opened this issue Jul 29, 2021 · 4 comments
Open
Labels

Comments

@walterxie
Copy link
Contributor

@rbouckaert
PrunedRelaxedClockModel has the code to assume UCRelaxedClockModel meanRate is RealParameter. I add the code to cast it into RealParameter after meanRate is changed to Function .

Please review my bug fix and close this issue if you are happy with the solution.

@rbouckaert
Copy link
Contributor

rbouckaert commented Jul 29, 2021

Thanks for fixing! I start to think this should be reverted and made available for v2.7, since it breaks a few other clock models as well and causes an API change.

@rbouckaert
Copy link
Contributor

I reverted the RealParameter => Function change, but plan to roll it back for v2.7. Perhaps this change can be reverted as well and parked for now. Sorry for the hassle.

@walterxie
Copy link
Contributor Author

You do not need to revert the code for this fix. It works when meanRate is either RealParameter or Function .

@rbouckaert
Copy link
Contributor

Good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants