Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name clash #4

Open
gavryushkina opened this issue Sep 7, 2016 · 4 comments
Open

Name clash #4

gavryushkina opened this issue Sep 7, 2016 · 4 comments

Comments

@gavryushkina
Copy link

In the main beast2 package there is also test.beast.evolution.likelihood.TreeLikelihoodTest class.

@tgvaughan
Copy link

Yikes, 4 years later and this is still an issue. It doesn't cause huge problems in practice because the package JARs that are distributed don't usually include the test classes, but it could cause headaches in other cases.

Would it be possible to rename the BEASTLabs class likelihood test class?

@kche309
Copy link

kche309 commented Jun 9, 2021

I've also had this issue come up when building beast2/BEASTLabs.
Perhaps we can rename the BEASTLabs class to TreeLikelihoodBeastLabsTest?

@walterxie
Copy link
Contributor

you should use your own namespace for developing your models, for example, do not use beast.evolution.errormodel, instead you could use phylonco.evolution.errormodel. Then you do not have to worry your classes names will be conflict with other packages.

@kche309
Copy link

kche309 commented Jun 9, 2021

Thanks Walter. This is a BEASTLabs name clash with beast2, so we would have to either use a different namespace test.beastlabs.evolution.likelihood or rename the BEASTLabs TreeLikelihoodTest class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants