Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error for Stern Honors Seminar #319

Open
A1Liu opened this issue Jan 14, 2023 · 6 comments
Open

Parsing error for Stern Honors Seminar #319

A1Liu opened this issue Jan 14, 2023 · 6 comments

Comments

@A1Liu
Copy link
Collaborator

A1Liu commented Jan 14, 2023

The correct subject code for Honors Seminar is "HONR-UB", but Schedge is parsing it as "non-credit)" during scraping.

School Code: GB
School Name: Leonard N. Stern School of Business
Subject: Honors Seminar
Subject Code: "non-credit)"

@A1Liu A1Liu changed the title Parsing error for stern honors courses Parsing error for stern honors subject Jan 14, 2023
@A1Liu A1Liu changed the title Parsing error for stern honors subject Parsing error for Stern Honors Seminar Jan 14, 2023
@MDK8888
Copy link
Contributor

MDK8888 commented Jan 31, 2023

Hey, I would love to pick this up!

@A1Liu
Copy link
Collaborator Author

A1Liu commented Feb 1, 2023

That'd be awesome! Take a look at parseTermPage in https://github.com/A1Liu/schedge/blob/main/src/main/java/scraping/PSClassSearch.java , it'll hopefully be close to where the parsing bug actually is.

Also, don't hesitate to reach out! I'm available to answer questions or pair program if that would be helpful.

@MDK8888
Copy link
Contributor

MDK8888 commented Feb 2, 2023

Hey @A1Liu, thank you so much for guiding me towards that resource, I really appreciate it! I was wondering if there were additional resources to understand the error, i.e. where do we input the above information about the Stern course, and what does the stack trace say when Schedge bugs out?

@A1Liu
Copy link
Collaborator Author

A1Liu commented Feb 2, 2023

Hey, sorry the issue isn't clear right now, the problem is that Stern's Honors Seminar has the code "HONR-UB" and "HONR-GB", but Schedge is parsing it as "non-credit)". There's no error thrown, it's more of a problem of outputting the proper data.

@A1Liu
Copy link
Collaborator Author

A1Liu commented Feb 2, 2023

You should be able to test the code that gets subject information using yarn scrape schools --term=sp2023, which will then run the scraper code on the pages at sis.nyu.edu

@MDK8888
Copy link
Contributor

MDK8888 commented Feb 4, 2023

Hey @A1Liu, thanks so much for this-I will definitely check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants