Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug dummy app assertion error #21

Closed
Windvis opened this issue Aug 28, 2019 · 2 comments · Fixed by #26
Closed

Debug dummy app assertion error #21

Windvis opened this issue Aug 28, 2019 · 2 comments · Fixed by #26

Comments

@Windvis
Copy link
Contributor

Windvis commented Aug 28, 2019

When clicking around in the dummy app, the following error is being thrown:

Error: Assertion Failed: You modified "breadcrumbContainers" twice on <dummy@component:breadcrumbs-item::ember143> in a single render. It was rendered in "component:breadcrumbs-item" and modified in undefined. This was unreliable and slow in Ember 1.x and is no longer supported. See https://github.com/emberjs/ember.js/issues/13948 for more details.
@Windvis
Copy link
Contributor Author

Windvis commented Aug 28, 2019

Seems related to the internal code refactoring. Commits before that don't show the error. FUUUuuUuuUuuuuuuuuuuuuuuuuuuuuuu....

@bertdeblock
Copy link
Contributor

might be related => emberjs/ember-render-modifiers#11?

@bertdeblock bertdeblock mentioned this issue Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix modifying "breadcrumbContainers" twice Bagaar/ember-breadcrumbs
2 participants
@Windvis @bertdeblock