Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Remove the ember/alias-model-in-controller rule as it does not work correctly #3

Open
bertdeblock opened this issue Feb 1, 2019 · 3 comments

Comments

@bertdeblock
Copy link
Contributor

No description provided.

@Windvis
Copy link
Contributor

Windvis commented Feb 1, 2019

I think a better option is to disable the rule in the controller that triggers the false positive. It would make it explicit and would still catch valid mistakes that way.

@bertdeblock
Copy link
Contributor Author

👍

@Windvis Windvis reopened this Sep 4, 2019
@Windvis
Copy link
Contributor

Windvis commented Sep 4, 2019

Reopening because this rule is a major PITA if you don't actually use the model hook. The rule doesn't check if a route with a model hook exists, so it throws a lot a false positives in projects that fetch data in the controller / components.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants