Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary state variable event shapes in dynamical systems #347

Open
eb8680 opened this issue Oct 18, 2023 · 0 comments
Open

Support arbitrary state variable event shapes in dynamical systems #347

eb8680 opened this issue Oct 18, 2023 · 0 comments
Assignees
@eb8680
Labels
enhancement New feature or request module:dynamical
Milestone
Cleanup after ASK...

Comments

@eb8680
Copy link
Contributor

eb8680 commented Oct 18, 2023

Currently chirho.dynamical.simulate assumes individual state variables are scalar torch.Tensors (i.e. tensors with event_dim == 0). This was only imposed to simplify the implementation of the torchdiffeq backend, not for any deeper reason, so we should generalize to support arbitrary state variable shapes/types.

It will likely be necessary to resolve #328 before this issue can be resolved.
@eb8680 eb8680 added enhancement New feature or request module:dynamical labels Oct 18, 2023
@eb8680 eb8680 added this to the ASKEM November 2023 hackathon milestone Oct 18, 2023
@eb8680 eb8680 self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eb8680 eb8680

Labels
enhancement New feature or request module:dynamical
Projects
None yet
Milestone
Cleanup after ASKEM November 2023 hac...
Development

No branches or pull requests
1 participant
@eb8680