Wrong language field used in option key

[nlemoine]

Version information

• Plugin version : dev-master
• PHP : 7.3.3
• WordPress : 5.2.1
• ACF version : 5.8.0
• Polylang version : 2.5.4

You chose the locale field from Polylang to distinguish option keys (eg. options_fr_FR_my_key, options_en_US_my_key, etc.). The problem is that you can store multiple languages with the same locale whereas you can't with the same slug. Polylang forbids it.

Polylang isn't always used in a multilingual site. It can be used for a multi country site (you could have the same locale for two or more countries and not necessarily use sub locale).

This is of course quite an edge case issue but I think it's worth to be noticed and should be fixed in a future major release because it would introduce a BC issue.

[alexstrand]

We have now run into the same problem. It seems that the plugin is using the Polylanglocale field instead of the unique slug for each language. This means that if we have two languages using the same locale, the options data for those languages is shared.