Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrence Rules End Date does not include event occuring on the end date #156

Open
kyletcook opened this issue Nov 4, 2022 · 9 comments

Comments

@kyletcook
Copy link

Background

The recurrence rules function in the events form allows user to set the end date of a recurring event series. Bedework is set to consider the series to end on 11:59 p.m. of the date prior to the end date. While logic would suggest an "end date" not include events on the ending date, and technical conventions may require this, my users do not interpret it thus.

Example: 1st Thursday Book Club occurs on first thursday of months of March April May, 2023. User sets begin date to Thursday, March 2; end date to Thursday, May 4.

every month(s) on the first Thurepeating until 2023-05-04

Expected

Based on repairing this error for users, I observe most users expect the end date to include events occuring on the end date (May 4). This convention is consistent with their company's enterprise calendar recurrence setting which includes events scheduled on the end date.

Proposed Fix

At least on the Add Event forms, when user selects an end date to a series, events that fall on this day should be included in the series.

@douglm
Copy link
Member

douglm commented Nov 4, 2022 via email

@spartanicus
Copy link
Member

spartanicus commented Nov 4, 2022 via email

@douglm
Copy link
Member

douglm commented Nov 4, 2022 via email

@kyletcook
Copy link
Author

This is a pre-existing issue present on current Nashville prod, and Nashville eventsdev. So, not specific to the present upgrade process.

This has been an issue for a long time (years). Not urgent to fix on project before deploying next version on Nashville. Should wait. Added to Bedework Issues instead.

I am noticing a trend that more users are having trouble interpreting that range-picker than in past years. Although I've always pointed it out while showing the interface in training. Of four users who added recurring events today, three made this entry error.

@douglm
Copy link
Member

douglm commented Nov 4, 2022 via email

@kyletcook
Copy link
Author

We also have problem with users leaving the default 'forever'. Is this option you refer to as no-end-date?

Screen Shot 2022-11-04 at 3 05 20 PM

@douglm
Copy link
Member

douglm commented Nov 4, 2022 via email

@kyletcook
Copy link
Author

Affirmative to disabling this option for all users. We never want to have users able to select 'forever'

@kyletcook
Copy link
Author

To original issue: I believe we were able to address this in the UI before--by adding a value of +1 somewhere in the settings. I can't locate this option now. However, our users are once again running into the problem while using the Repeat: until.

Users identify this repeat completion date as the last occurrence of the series, instead of the end of the logical date range during which the series repeats (the day after).

Our users' behavior replicates functionality of Outlook calendar's use of End Date, their UI describes this as Occurs every _Wednesday_ until

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants